Skip to content
OverviewSolutions
10
Comments
10
P
EfthymiosK
@EfthymiosK

All comments

  • Gideon•50
    @Gamson3Submitted about 1 month ago
    What are you most proud of, and what would you do differently next time?

    We are proud of how well we implemented responsive design, ensuring the newsletter sign-up form looks great on both desktop and mobile devices. The layout adapts to different screen sizes without sacrificing usability, and the hover and focus states give the form an interactive feel. The JavaScript form validation is also a success, with clear error messages for invalid emails, enhancing user experience.

    What challenges did you encounter, and how did you overcome them?

    One key challenge was ensuring that the form worked seamlessly on different screen sizes while maintaining its design integrity. We overcame this by carefully setting up media queries and testing extensively on various devices to ensure consistent behavior across mobile and desktop.

    What specific areas of your project would you like help with?

    Would appreciate feedback on optimizing the JavaScript code used for form validation. Specifically, any suggestions for simplifying the validation logic or improving error handling would be helpful. Additionally, advice on improving the accessibility of the form, especially regarding the handling of error messages for screen readers, would be valuable.

    Newsletter sign-up form with success message

    1
    EfthymiosK•180
    @EfthymiosKPosted about 1 month ago

    hi! The success card in mobile is not responsive,other than that you did an excellent job! Well done!

    Marked as helpful
    0
  • EfthymiosK•180
    @EfthymiosKPosted about 2 months ago

    hi!

    The title font size should be a little bigger and it looks like there is no box shadow round the component. Also the share svg should change color when pressed. Other than that it was an almost perfect try! Keep up the good work!

    0
  • nimrodEDE•190
    @nimrodEDESubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    This is a big project for me , it took me a while but i managed to create the site and make it responsive !

    What challenges did you encounter, and how did you overcome them?

    thinking about all the layout .

    What specific areas of your project would you like help with?

    I believe that i do not use the best practices , i'd like to improve with that.

    thanks :)

    Premium Challenge || Meet landing page

    1
    EfthymiosK•180
    @EfthymiosKPosted about 2 months ago

    Nice try, keep up the good work!

    0
  • EfthymiosK•180
    @EfthymiosKPosted about 2 months ago

    Hi,

    • You haven't created a mobile version of the site!
    • The dimensions of the elements are not accurate but this is understandable since you don't have the Figma design.
    • On the top left testimonial the border of the image should be purple.
    • You haven't included the background image. Other than the above, it was a good try! Keep up the good work!
    Marked as helpful
    1
  • gio•120
    @fakegioSubmitted 2 months ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of getting the project to look similar to the design. Next time, I would focus more on getting the spacing right.

    What challenges did you encounter, and how did you overcome them?

    The challenge I encountered was the grid container on the desktop version wasn't working correctly as intended, this was solved by realizing i selected the wrong element.

    What specific areas of your project would you like help with?

    Semantics

    Responsive four card feature section

    1
    EfthymiosK•180
    @EfthymiosKPosted 2 months ago

    Excellent job! Couple details I can mention is that you should begin by H1 and not H2 (https://dequeuniversity.com/rules/axe/4.6/heading-order?application=axeAPI), and that your mobile version is not responsive from 320px. Other than that, well done!

    0
  • EfthymiosK•180
    @EfthymiosKPosted 2 months ago

    Well done! Looks excellent except for the H1 that should have (according to figma) font weight 700 insteed of 900. Keep up the good work!

    Marked as helpful
    1
  • Ner046•60
    @Ner046Submitted 2 months ago
    What specific areas of your project would you like help with?

    I am sure I missed many small details as I rushed it a bit, tell me if there are big issues that can easily be fixed or something I should not do going forward

    Responsive recipe page HTML + CSS

    1
    EfthymiosK•180
    @EfthymiosKPosted 2 months ago

    hi! I can mention some of the diferences I see between the design and your solution:

    -The card container needs more border-radius and as well as the image. -The card dimensions dont look acurrate. Yours look wider than design. -You need to pick the right color for the text in your lists and paragraphs. -In design there is more space between lines in the ingredients list. Perphaps add some padding or margin.

    • The first column of your table needs lef padding. you can achieve that by adding a class to the first column tds and using it in CSS. Overall I think it was a good try and with some improvement it will be perfect!
    0
  • EfthymiosK•180
    @EfthymiosKPosted 2 months ago

    Hi my friend! Overall very good job, only two things I can mention: - The dimensions of the main container don't look exact, the one in the design looks smaller.

    • The margin under the avatar-photo looks much bigger in the design (I mean the distance between the photo and the H1). Other than that your code is well-structured except that you should always use an H1 in a website. Keep up the good work!
    0
  • EfthymiosK•180
    @EfthymiosKPosted 2 months ago

    Hi my friend! Overall very good job! Just the "learning" element has more padding and less border-radius in the figma-design. Also perphaps you have made the image-avatar a bit larger than it should be. Finally, you propably shouldn't incude the atributions element. Keep up the good work!

    0
  • EfthymiosK•180
    @EfthymiosKPosted 2 months ago

    Hi my friend! - First of all, I think that you should totally remove the attribution div. As you can see on your own there is no such thing on the original design. - If you look at the figma file you will see that the actual dimensions of the component are 320px x 499px. Yours is smaller (inspect with chrome dev tools to see for yourself). - You are using an H2 tag insteed of an H1. There should always be an H1 in a website (I learned that from tests frontendMentor did to my code). - You don't use semantic HTML. Perphaps after <body> you should include all your code in a <main> . Other than the above, I think it was a good try!

    0