pnchakrn• 20
@ndPnachkrn
Submitted
P
EfthymiosK
@EfthymiosK
All comments
- PEfthymiosK• 30
@EfthymiosK
Posted
Hi my friend! Overall very good job, only two things I can mention: - The dimensions of the main container don't look exact, the one in the design looks smaller.
- The margin under the avatar-photo looks much bigger in the design (I mean the distance between the photo and the H1). Other than that your code is well-structured except that you should always use an H1 in a website. Keep up the good work!
0 - Ablazed flame• 70
@Ablazed-flame
Submitted
PEfthymiosK• 30@EfthymiosK
Posted
Hi my friend! Overall very good job! Just the "learning" element has more padding and less border-radius in the figma-design. Also perphaps you have made the image-avatar a bit larger than it should be. Finally, you propably shouldn't incude the atributions element. Keep up the good work!
0 - Ahmed• 10
@ahmeddin12
Submitted
PEfthymiosK• 30@EfthymiosK
Posted
Hi my friend! - First of all, I think that you should totally remove the attribution div. As you can see on your own there is no such thing on the original design. - If you look at the figma file you will see that the actual dimensions of the component are 320px x 499px. Yours is smaller (inspect with chrome dev tools to see for yourself). - You are using an H2 tag insteed of an H1. There should always be an H1 in a website (I learned that from tests frontendMentor did to my code). - You don't use semantic HTML. Perphaps after <body> you should include all your code in a <main> . Other than the above, I think it was a good try!
0
