Skip to content
OverviewSolutions
5
Comments
3
Macaulay Eden
@EdenExperiments

All comments

  • Macaulay Eden•130
    @EdenExperimentsPosted over 2 years ago

    Congratulations on the completion of this one, your design looks very spot on!

    Feedback:

    • You could add some anchor tags to your daily/weekly/monthly toggles to make it accessible, I currently can't focus on them with my tab key.

    • Your desktop breakpoint is very low, smaller than an iphone pro and this is currently what it looks like on similar to iphone pro dimensions https://snipboard.io/Gti2Br.jpg, i'd consider changing it to 1024px+.

    • There's a tiiiny amount of the background on the cards poking out of the bottom corners on the stat cards, being very picky here as it's hard to find flaws in your design!

    Your JS is also looking good, there is potential for improvement by following DRY (do not repeat yourself), you have 3 very similar functions, could you use one with parameters? However it is very readable the way that it is and I'm just being picky.

    Marked as helpful
    0
  • Macaulay Eden•130
    @EdenExperimentsPosted over 2 years ago

    Consider how this would look to a user, yes it does scale nicely but how does it actually look on devices?

    link to image

    Above is how it looks on an Iphone 12 pro, so much space is margin and could be effectively used more, also, this is going to look tiny and the text is not accessible.

    A solid attempt however I do want to say! :)

    Marked as helpful
    1
  • Macaulay Eden•130
    @EdenExperimentsPosted over 2 years ago

    The question containers need a different or responsive height on mobile, the text begins to overlap onto the one underneath on the first two for widths < 440px, which is effectively all mobiles the size of an iphone pro max and under.

    Really like the transition in and out of the active state for the showing and hiding of text.

    Marked as helpful
    0