@PedroEustaq
Submitted
What specific areas of your project would you like help with?
Any help is welcome!
@DylandeBruijn
@PedroEustaq
Submitted
What specific areas of your project would you like help with?
Any help is welcome!
@DylandeBruijn
Posted
@PedroEustaq
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
You don't have to put width: 100vw
on the body
element. It already takes up the full width of the html
tag. Which in turn takes up the full width of the viewport, which is 100vw.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
Try making your solution more reponsive.
I suggest using a p
tag for "Learning".
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
@keethesh
Submitted
What are you most proud of, and what would you do differently next time?
I have been able to reproduce the design quite quickly while still maintaining, I think, a decent similarity
What challenges did you encounter, and how did you overcome them?
I had difficulties with making my design completely responsive.
What specific areas of your project would you like help with?
I know that there is a better way to do the tag background, but I am not sure how.
@DylandeBruijn
Posted
@keethesh
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using semantic HTML elements like main
, section
and article
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
I suggest using px
for the width
of the card.
I suggest using proper tags for you headings and text, like h1
and p
.
You have some overflow issues on smaller viewports.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@GamingClaus
Submitted
What are you most proud of, and what would you do differently next time?
i am proud of how close it is replicated and next time i would wanna try grid layout and make it look better
What challenges did you encounter, and how did you overcome them?
there weren't much problems during this challenge as my previous challenge helped me learn how to talked those sort of problem the only problem i faced was when my img width was 300px so it was making the other items overflow so i used 100% width to fix that problem.
What specific areas of your project would you like help with?
If there are anything i need to improve please let me know
@DylandeBruijn
Posted
@GamingClaus
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using semantic HTML elements like main
, section
and article
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
You donβt have to wrap your image in a separate div
, itβs possible to style it directly to achieve the same result.
You don't have to use negative margins to layout your elements. Negative margins do have their place when developing websites but I recommend not using them how you used them in this project.
I recommend using a p
tag for "Learning".
To prevent an img
tag from overflowing you can add max-width: 100%
to it.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
What are you most proud of, and what would you do differently next time?
I am very happy with the help that doing these projects provides, I feel that I improved a lot in covering details. If there is something I would improve it would be the way I apply sizes and measurements. Regarding the rest I am very happy. β€
What challenges did you encounter, and how did you overcome them?
I had a little difficulty making the size of the card and the other elements as close to the project example without using pixels, so instead I used em and rem. In the end I was able to apply them after several tests with measures that I think could be improved for next time.
What specific areas of your project would you like help with?
I would like help with the measures I applied, I'm not entirely sure if they are correct or if there are better ways to apply them.
@DylandeBruijn
Posted
@RomPirsZ
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using semantic HTML elements like main
, section
and article
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
Be careful with setting a fixed width
and height
on your elements. If the content in these elements grows beyond these restrictions youβll run into overflow issues. Keeping the height
at auto
- which block
elements are by default - will be fine in most cases.
You donβt have to wrap your image in a separate div
, itβs possible to style it directly to achieve the same result.
Try centering your card using Flexbox instead of padding
and margin
.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@Fikriraihan
Submitted
What are you most proud of, and what would you do differently next time?
The most proud things I did in this project is I finally write a README.md
What challenges did you encounter, and how did you overcome them?
Theres no specific challenges. I'm just happy that I go back to learn about the basic of web development
@DylandeBruijn
Posted
@Fikriraihan
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage.
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using semantic HTML elements like main
, section
and article
.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
@burnacode
Submitted
What are you most proud of, and what would you do differently next time?
completing the challenge
@DylandeBruijn
Posted
@burnacode
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
The attribution text is a bit hard to read, I suggest using a different color.
To my knowledge the <main-body>
tag is not an official HTML tag. A <body>
with a <main>
inside should be enough in your case. You can remove the <main-body>
tag.
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
Try putting your links in a list (ul
) to make your code more semantic.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@GamingClaus
Submitted
What are you most proud of, and what would you do differently next time?
To be honest i am proud of my work overall. and i am hoping to try use different layouts next time.
What challenges did you encounter, and how did you overcome them?
I didn't encounter many problems while doing this challenge as my previous challenge helped me learn a lot and I fixed those problems here.
What specific areas of your project would you like help with?
If there are anything i need to improve please let me know
@DylandeBruijn
Posted
@GamingClaus
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
Try using semantic HTML elements like main
, section
and article
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
Try putting your links in a list (ul
) to make your code more semantic. I also suggest using a
tags instead of a button
for you links.
You donβt have to wrap your image in a separate div
, itβs possible to style it directly to achieve the same result.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@Rokeeb01Maruf
Submitted
What are you most proud of, and what would you do differently next time?
I'm proud to be able to finish my first project. Next time I will improve my speed of designing
What challenges did you encounter, and how did you overcome them?
I encountered some challenges but I revised my materials to solve them
What specific areas of your project would you like help with?
None for now
@DylandeBruijn
Posted
@Rokeeb01Maruf
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using semantic HTML elements like main
, section
and article
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
You donβt have to wrap your image in a separate div
, itβs possible to style it directly to achieve the same result.
Try making your solution more responsive.
Try using the right semantically right HTML tags, like h1
or h2
for the title of your recipe.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@Atatra
Submitted
What are you most proud of, and what would you do differently next time?
Not much to say about this one
@DylandeBruijn
Posted
@Atatra
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution π
Things you could improve βοΈ
padding
to your body
element so the card has some space around it on smaller viewports.I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@Deepa-Vimal
Submitted
What are you most proud of, and what would you do differently next time?
css box model learned
What challenges did you encounter, and how did you overcome them?
css
@DylandeBruijn
Posted
@Deepa-Vimal
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
I suggest using clear descriptive CSS classes like .card
, .card-title
and .card-description
.
Try using semantic HTML elements like main
, section
and article
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
Try putting your links in a list (ul
) to make your code more semantic.
Try using an a
tag instead of a button
for your links.
You have some unused Flexbox properties on your container.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
@0xblu
Submitted
@DylandeBruijn
Posted
@0xblu
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things you could improve βοΈ
I suggest adding a bit of padding
to your body
element so the card has some space around it on smaller viewports.
Try experimenting with the CSS layout tool Flexbox, it will help you greatly structuring elements on your webpage.
You could add a min-height: 100vh
to your main
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try experimenting with CSS variables, they help you make your CSS values more reusable across your code.
Try using semantic HTML elements like main
, section
and article
.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
Try putting your links in a list (ul
) to make your code more semantic.
Try replacing your button
elements with a
tags.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful
What are you most proud of, and what would you do differently next time?
I spent a bit more time on this project making sure that the design worked for all screen sizes from a viewport width of 320px up to more than 1440px.
What challenges did you encounter, and how did you overcome them?
Thanks to amazing suggestions of @DylandeBruijn and @danielmrz-dev, I started with a clunky solution that involved using background images for the photos, and moved toward a much more flexible responsive images solution that works well across screen sizes and treats the product images as part of the content.
@DylandeBruijn
Posted
@elisilk
Hiya! π
Congratulations on your solution, it looks very close to the design! I can tell you put a lot of effort into it.
Things I like about your solution π
Things you could improve βοΈ
You could add a min-height: 100vh
to your body
element so it takes up the full height of the viewport while still being able to grow when the content inside it grows.
Try using using relative CSS units like rem
and em
they make your layout more adaptable.
I recommend looking into the picture
element to achieve the desired effect of having different images on different viewports.
I recommend using a p
tag for the category.
I hope you find my feedback helpful! π
Let me know if you have more questions and I'll do my best to answer them. πββοΈ
Happy coding! π
Marked as helpful