@Divyamsharma-18
@mahmoud17-cmyk
Submitted
What are you most proud of, and what would you do differently next time?
controlling
What challenges did you encounter, and how did you overcome them?
I face all my challenges
What specific areas of your project would you like help with?
it was a great project
@Divyamsharma-18
Posted
good job, but there are a few things which you can improve like the quotes should be down, margin or padding could've helped
@filipjuszczak
Submitted
@Divyamsharma-18
Posted
Looks great buddy :)
@aduatgit
Submitted
What are you most proud of, and what would you do differently next time?
I think I did a good job starting from the mobile design and adjusting the desktop design afterwards. I did this layout with flex, but I think grid would have made things a bit easier when swapping from mobile to desktop.
What challenges did you encounter, and how did you overcome them?
I had a huge space at the bottom of the product information when on desktop, I bandaid fixed that by adjusting the flex-gap, but again, using grid would probably have solved this more elegantly. In general the spacing was quite weird to get right, in the end I didn't really bother to make things pixel perfect, especially because I wasn't working with a figma file.
I had some issue with the button shopping cart picture, but I managed to solve that using a pseudoelement. The problem that persisted was that it wasn't really centered, but I found out that you could use the image as a background instead of putting it in the content of the pseudoelement, that way it became centered.
What specific areas of your project would you like help with?
Is it possible to use flex to fill up the right area (-> the product information) dynamically, without having to use gap and fixed heights and eyeballing it to get it right? I know it is possible with grid, but would really like to know if it is possible with flex.
@Divyamsharma-18
Posted
Looks great buddy :) Keep it up!
@mfsantosz
Submitted
What are you most proud of, and what would you do differently next time?
I managed to do everything alone
What challenges did you encounter, and how did you overcome them?
Placing the image in website. Just with widget, display etc
What specific areas of your project would you like help with?
At the moment none
@Divyamsharma-18
Posted
Looks exactly same buddy, I changed min a lil bit, cause I liked it that way!!
@jessegile
Submitted
What are you most proud of, and what would you do differently next time?
It took me a bit to get the footer to stay at the bottom
I think I would write down the sections before starting next time so that I could look up anything I was unfamiliar with...maybe
What challenges did you encounter, and how did you overcome them?
As above, the footer.
I looked up the answer online.
What specific areas of your project would you like help with?
Any criticism is welcome!
@Divyamsharma-18
Posted
Looks great buddy, keep it up :)
@andrew-j-brown
Submitted
What are you most proud of, and what would you do differently next time?
I am most proud of achieving mobile responsiveness with the card, however, I would probably look for a cleaner way to achieve the scaling text next time.
What challenges did you encounter, and how did you overcome them?
I had an issue with the svg image not scaling to the size of the card - it worked fine until shrinking the bounds of the screen, whereupon the card would not adjust it's size. It was able to do this if I removed the svg, and thus determined it was an image scaling issue. I ended up using the following solution:
.article-illustration {
max-width: 100%;
border-radius: 8px;
}
For the scaling text, I used the clamp tool as follows:
h1 {
font-size: clamp(1.2rem, 5.5vw, 1.5rem);
font-weight: 900;
}
p {
font-size: clamp(0.8rem, 3.6vw, 1rem);
}
This works, however it was a bit clumsy trying to find the right vw amounts to get them both to shrink consistently with each other.
What specific areas of your project would you like help with?
I would appreciate a better solution for the responsive text, thanks!
@Divyamsharma-18
Posted
Good work buddy :) Keep it up!
@hemu2253
Submitted
What are you most proud of, and what would you do differently next time?
I have used CSS Grid method to show responsiveness
What challenges did you encounter, and how did you overcome them?
I targeted using CSS Grid for responsive as it has the flexibility of controlling the grid for multiple screens.
@Divyamsharma-18
Posted
Hey, good work, keep it up, one issue I saw was you can correct is, info was written in 3 lines and you did it in 2 lines, otherwise good job :) Also the code looks good too.
Marked as helpful
