Skip to content
OverviewSolutions
28
Comments
54
Diarrah
@Diarrah

All comments

  • Diarrah•3,418
    @DiarrahPosted almost 4 years ago

    Looks familiar

    0
  • Diarrah•3,418
    @DiarrahPosted about 4 years ago

    My man, this project is awesome! I've had it bookmarked for a while and always come back to look at the functionalities.

    I have a question: how is it that all the data still shows up when the PWA is downloaded to my laptop but there is no wi-fi? When I use the PWA with no connection everything is the same. Sometimes I have used PWAs and when they are grabbing info from and API & there is no connection the PWA will just give out a message that says: Sorry, please connect to internet.

    Can you answer this for me if you can? Thanks!

    1
  • Diarrah•3,418
    @DiarrahPosted about 4 years ago

    Good job! I thought I was fast doing this project but you were super fast lol.

    The 2 things I noticed is that it's a bit verbose with the stories page - I did a simple JSON & it was pretty simple with the pictures like that. Also, when mobile nav is out + you redirect to a page the nav remains out. You can make it go in with a really simple useState.

    Hope this helps :)

    -Diarrah

    2
  • Diarrah•3,418
    @DiarrahPosted about 4 years ago

    Good job! When I did this project I tried to take the extra bonus of the map API but I used Google maps & just could not decipher the documentation. You did it amazingly!

    1
  • Diarrah•3,418
    @DiarrahPosted about 4 years ago

    Whenever I change to color of my SVG icons I usually just make a whole nother icon. What I do it just copy & paste the code, make another .svg file & copy that code over & then put the correct hex code in place where it says "fill" or "stroke".

    If you want to change it in the CSS itself you have to copy over the whole SVG code over into the HTML itself.

    I can explain more if needed but I hope this helps!

    Marked as helpful
    1
  • Diarrah•3,418
    @DiarrahPosted about 4 years ago

    You can add a transition by making the answer portion of the FAQ a max-height of 0 and then when you push the button you make it the full height. If you look at my solution to this you will see what I'm talking about. Hope that helps.

    1
  • Diarrah•3,418
    @DiarrahPosted about 4 years ago

    There isn't really a way to tell if your solution is pixel perfect beforehand unless you're a PRO and you have the Sketch file that gives you really specific values.

    0
  • Jan•500
    @eljasiuSubmitted over 4 years ago

    Hello, this is my solution of this challange. I find this project quite challanging, but I think I did well. If you noticed any issues, feel free to comment. Any feedback would be highly appreciated. I hope you a have good day, warm wishes, Jan

    Pretty damn good solution to Insurance landing page

    2
    Diarrah•3,418
    @DiarrahPosted over 4 years ago

    I love the confidence in the title to this solution & I agree with you that you did a pretty good job! Only suggestion would be to make sure that the patterns fit correctly when you resize the window & maybe put a set width on the buttons.

    2
  • Diarrah•3,418
    @DiarrahPosted over 4 years ago

    Your code is so good! Love the trick how you mapped the cards in the stats section. Also love your hover effect on the buttons + the mobile nav deploy.

    I have on thing I don't understand though which is the cta-box mixin. Could you explain that if you have time? Thank you!

    2
  • Diarrah•3,418
    @DiarrahPosted over 4 years ago

    Code looks great!

    I've experimented with styled-components a few times & thought it was a bit confusing but your code makes it really clear!

    1
  • Diarrah•3,418
    @DiarrahPosted over 4 years ago

    Good job on your solution! 🎉

    I would make a few recommendations: ・Make the body a min-height: 100vh and display: flex so that the wrapper will centered in the middle of the page. ・I wouldn't out a 25vh margin above & below on the wrapper I would just make it auto. ・When resizing I would make the wrapper flex-direction: column. ・It's not good practice to put the word "picture" or "image" in an alt tag because screen-readers automatically add that word anyways when they're reading an img tag

    Hope that helps! Diarrah

    1
  • Diarrah•3,418
    @DiarrahPosted over 4 years ago

    Logic is all there + perfectly legible but I would add some more styling to make transitions smoother and make the font more uniform.

    0