Skip to content
OverviewSolutions
8
Comments
18
Ibtissam
@Devibtissam

All comments

  • Ibtissam•260
    @DevibtissamPosted about 2 years ago

    well done, you can add alt attribute to the img elements to fix your report issues shown above.

    1
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    Hi! it's important to be aware of HTML semantic structure, your page should at least have on heading level, apart from that you did a great job, keep up

    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    Hi, well done on this challenge,

    • to fix the accessibility issue, you can add aria-hidden = true to your <i></i> element, for better understanding check this link : https://a11y-101.com/development/icons-and-links I've done already this challenge and I didn't make icons clickable, so great job, keep up
    Marked as helpful
    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    Hi,

    • in addition to what Florent mentioned, try to find a way to remove all the styles of errors occurred when the user starts again typing, you can do that by using the event keypress and loop throughout the input fields.
    • it's important the be aware of HTML semantic structure, each section article .. should have at least one heading level, and all heading levels should be increased only by one.

    hope this helps!

    Marked as helpful
    1
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    Hi,

    • It's important to be aware of HTML semantic structure, you cannot skip heading level like this, and your page should at least contains one-level heading h1, and all headings level should be increased by one, h1 then h2, h3, and so on ...
    • a part that you did well on this challenge, keep up
    Marked as helpful
    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    Hi, well done on this challenge

    • Heading levels should only increase by one, you can not put h1 and then h3 , you should use h2 instead hope this helps :))
    1
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    hey, good job on this challenge!

    • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=" "; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead.
    • your page should at least contains one-level heading h1
    • input attribute should not be empty, you could remove them if you don't want to fill them hope this helps you to fix the issues shown above in your report!
    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    hey, good job on this challenge! wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=" "; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead

    Marked as helpful
    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    hey, good job on this challenge! wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=" "; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead

    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    hey, good job on this challenge! wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=" "; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead

    • your page should at least contains a one-level heading and all headings levels should only increase by one , you can not put h1 and then h5 and then back to h2 and so on, hope this can help you to fix your accessibility issues !
    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    hey, good job on this challenge! wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=" "; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead heading levels should be increased only by one you can not have in the first section h1 and then h3 and then back to h2 and so on and for proper design it likely to use padding 100% auto instead of margin because you need space around the inside content and not outside it hope this helps

    Marked as helpful
    0
  • Ibtissam•260
    @DevibtissamPosted over 2 years ago

    hey, good job on this challenge! wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=" "; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead

    hope this helps

    Marked as helpful
    0