Skip to content
OverviewSolutions
3
Comments
2
Des2Dev
@Des2Dev

All comments

  • BISHNU POKHREL•10
    @bisu22Submitted over 2 years ago

    While building this project I found difficulties in positioning div,elements and paragraphs. I am unsure of how to position heading right below the QR code image where the text and image are symmetric .

    used div element as classes for css styling

    2
    Des2Dev•70
    @Des2DevPosted over 2 years ago

    Hi @bisu22,

    • you don't have a CSS folder in GitHub. Therefore you can either create a new folder and place your style.css file in that folder.

    OR

    • you can get rid of css/ path in your link, like this <link rel="stylesheet" href="style.css">.

    and same rule to your img element, <img src="image-qr-code.png" alt="QR code">. always try to add some text to alt=" " attribute.

    I think this feedback will helpful, and best wishes for your upcoming challenges.

    Marked as helpful
    0
  • Olabisi G. Adekoya•70
    @labisigloriaSubmitted over 2 years ago

    This is my first ever solution to a frontend mentor challenge, i had problems with creating the media queries for the challenge, i'm not even sure if the media query code i wrote is right according to the challenge, Please i'll appreciate a response on that and any other addition i should have made concerning my code.

    QR Code component challenge

    3
    Des2Dev•70
    @Des2DevPosted over 2 years ago

    Hi ! you did good, but there are some small changes you can do to make it more good.

    • you don't need media query @media in this challenge. Remove the media query.

    • And also use flexbox to center the card, and remove the margin properties from body.

    • And always try to use min-height property, not height.

    I thin this comment will helpful. and Good luck to your upcoming challenges.

    Marked as helpful
    0