gracepal• 430
@gracepal
Submitted
Deepu23456
@Deepu23456
All comments
- Deepu23456• 90
@Deepu23456
Posted
Hello @gracepal i am not a very pro in web development as i started learning from past 6 months so giving feedback is not an accurate term for me. But i saw your project it's very nice. The UI is awesome and functionality too. There are few things which not seems good to me as functionality.
-
When user select the amount for bill and when user select persons too and then tip % so user only able to choose 1 tip % after selecting it when user select other tip % it doesn't calculate the amount it just stuck on firstly touch tip it has to update the amount when user increase or decrease the tip % .
-
When user select the amount of bill and after filling the amount user should not be able to select tip before selecting the no. of person it should show error to user which is not present in you case.
-
As i said in first point when user increase or decrease or just change the tip % it doesn't update the result same as when user try to update the bill amount or no. of person it works same. Whenever there a change occur whether in tip % or Bill amount or in no. of person it should update the result also according to data.
That's all i noticed....by the way itis a great work of yours. The UI is so good. Keep learning and improving yourself is the key to success. Thank You....
0 -
- Carlos André• 60
@carlosChamp
Submitted
Deepu23456• 90@Deepu23456
Posted
Keep going
0 - Laxman-Male• 90
@Laxman-Male
Submitted
What are you most proud of, and what would you do differently next time?
review the code I updated few of the code in JS file and HTML file
What challenges did you encounter, and how did you overcome them?
I was doing the email validation by using old method but in this I learnt the new method of email Validation
Deepu23456• 90@Deepu23456
Posted
Ok i saw this webpage i found some issues following below:
- When the input is empty and we tap on the submit button it gave us error but as well as it submit the form and display the success message which is not correct So it should be corrected.
- When we submitted the form and success message displayed it does not contained the email which we fill in input means the email was hardcoded not dynamic it should display that email address which user put in the input so it should be dynamic.
- When success message displayed and when we tap on dismiss message it stayed there and didn't disappeared as name suggested and expected. So it should modified too. These are some issues with the same however CSS is pretty good but get be better. That's all by the way keep going by building small project and working on feedbacks makes you a pro coder. So keep learning and growing. THANK YOU
Marked as helpful
0 - Maobugichi• 130
@Maobugichi
Submitted
What are you most proud of, and what would you do differently next time?
when i first started this project out, i had a rough time with the pop up for the social media links. i was soon about giving up but after some research and perseverance i was able to pull through
What challenges did you encounter, and how did you overcome them?
how to create the pop up div positioning
What specific areas of your project would you like help with?
none yet
Deepu23456• 90@Deepu23456
Posted
the solution include semantic tags which are very useful for SEO.
0
