@DeclanLacey
@GaganRatakonda
Submitted
What are you most proud of, and what would you do differently next time?
Developed this component quickly while keeping it responsive.
What specific areas of your project would you like help with?
Any feedback would be appreciated.
Fantastic job! The one piece of advice I would have would be to keep a close eye on how the size of your component matches up with the given design. It seems like your is a bit smaller than the given design. If you have access to the Figma files it can be a big benefit as you can see the exact size that something is supposed to be. Keep up the good work!
@Mano4life
Submitted
if you think there's something I could have done with something better or more effective please let me know :)
Great job!
Other than the prices in your design being different (not sure if this was intentional or not) and the sizes of some elements being a bit too small in your design (you can find the exact pixel size in the Figma file to better match the designs) you overall did a nice job!
@eddybpro
Submitted
Hi, there
This is my solution for the fylo-dark-theme-landing-page challenge, using ReactJS and Vite.
Happy to hear feedback and advice:)
Great job overall!
One thing that I would work on would be pixel perfect design. By this I mean getting the CSS as close to the Figma design as you possibly can. If you look at them side by side you will notice some things are too big or too small compared to the Figma design. Really use Figma to your advantage as it will tell you the exact pixel size of most things in the desing.
Happy coding!
@ccrump1280
Submitted
What are some ways I could make my CSS code cleaner?
With this project I went with a desktop-first approach which I know is frowned upon. Is it ever appropriate to use a desktop-first approach?
I wouldn't say there have really been any scenarios where it made sense to do desktop first, and the main reason for that is that it is easier to do mobile first and usually saves you some work. As with the mobile design, you will set up the general way the sections look and just have to change the way they are placed or the sizes of text etc. Although for a small design like this its probably not the end of the world. Nice job overall!
Marked as helpful
