@dradvmSubmitted over 2 years ago
Dawid Kaczmarek
@Dawid2806All comments
- @Dawid2806Posted over 2 years ago
Hello @dradvm
Congratulations on your completed project👏🎆 I have a little feedback for you. //html 1.".attribution" put into style.css file and remove from html 2.Almost all your components are written in <div> this is not good practice, read about semantics 3.Complete the alt attribute in img //css
- "background-color: white !important;" this is not good practice 2.try to style by class not by tags
// Enjoy coding 🤩
1 - @NiranjanKBhatSubmitted over 2 years ago@Dawid2806Posted over 2 years ago
Hello Niranjan Bhat, //Html 1.you have two h1, please read about semantics, 2.your picture is not displayed //Css styling by tags is not good practice , style by class positioning by "postition" is not good practice, read about Flex or Grid
Marked as helpful0 - @Arantis-jrSubmitted over 2 years ago@Dawid2806Posted over 2 years ago
Hello, 1.your solution is not responsive, see how it looks on mobile devices
Marked as helpful0 - @gulamansari57181Submitted over 2 years ago@Dawid2806Posted over 2 years ago
Hallo Mohd Gulam Ansari 1.I recommend you style by class not by tag, think what would happen if you had more h3's, they would all be the same. 2.once you use rem and once you use px, decide on one. 3. position: relative; float: right; very bad practice, I recommend you flex or grid
Marked as helpful0 - @andximenesSubmitted over 2 years ago@Dawid2806Posted over 2 years ago
Hello André I recommend you to learn flex or grid, position is not a good practice in this project
1 - @AczosSubmitted over 2 years ago@Dawid2806Posted over 2 years ago
Update the alt attribute, your project is in English so why have html="pl", change <title>Document</title> document is not a good name
Very good project !
Marked as helpful1 - @AczosSubmitted over 2 years ago@Dawid2806Posted over 2 years ago
Hi, aczos please change your repository to public.
Marked as helpful1
