Skip to content
OverviewSolutions
8
Comments
3
David
@Daviddp96

All comments

  • Saad Hisham•1,750
    @Saad-HishamSubmitted about 1 year ago

    Hi there🙋‍♂️!

    This was one of the most challenging projects I've had fun completing. Here's what I did:

    • I added multi-calculation so that you can perform multiplication, addition, or anything else in the same line.
    • I added sounds on click, theme changes, and errors.
    • I added animations on theme changes and errors.

    I was inspired by the error animation of another developer on the platform, Alexandra. Thank you!

    I was going to add a history of calculations, but I felt it wouldn't be a good idea 😅

    🔥Animated calculator with sounds and theme switcher🔥

    2
    David•150
    @Daviddp96Posted about 1 year ago

    Love the sounds, the themes and the error notification.

    Overall nice but you can't do operations like "2/0.2" so that might be worth checking out and fixing!

    Nicely done!

    Marked as helpful
    3
  • David•150
    @Daviddp96Posted about 1 year ago

    Hey there,

    You could add flex to your left-box class!

    Here's how:

    .left-box {
    display: flex;
    flex-direction: column;
    align-items: center;
    justify-content: center;
}

    Now you'll notice the text below is moved left, but for that you just have to disable the transform you added transform: translateX(38%);

    When you want to center things within a small container such as this one, it's best to use flex, you could also use grid but I find this simpler.

    Marked as helpful
    0
  • Sourav Singha•80
    @souravs97Submitted about 1 year ago
    • Having little bit trouble with Regular Expressions in Javascript.
    • Bugs in email field, getting submitted even its input is not valid. *e.g: abcd@gmail *

    Newsletter Signup Form with Message

    2
    David•150
    @Daviddp96Posted about 1 year ago

    Hey there,

    Here's the fix to your regular expression:

    const mailFormat = /^[a-zA-Z0-9._]+@[a-zA-Z0-9-]+(?:\.[a-zA-Z0-9-]+)*\.[a-zA-Z]{2,}$/;

    The difference is that now it includes \.[a-zA-Z]{2,} at the end

    This ensures that the domain extension consists of at least two alphabetic characters. As a result, only email addresses with a valid domain extension like ".com", ".net", or ".org" will be considered valid.

    Also since it's a submit button you could consider using the submit event instead of the click event.

    Cheers

    Marked as helpful
    0