Skip to content
OverviewSolutions
4
Comments
4
David
@Dav1dGP

All comments

  • David•60
    @Dav1dGPPosted 7 months ago

    Hi there!!

    First of all, good job!!

    Here are some suggestions for your solution:

    The alt attribute in the <img> tag should have descriptive text and you have it empty. This attribute is important because it is what will appear if the image fails.

    On the other hand, in HTML5 it is more semantically correct to have the <footer> tag inside the <body> tag and not outside of it.

    Finally, you have given a touch of different color to the design, but if you like it better this way, perfect.

    Good luck in your next projects and enjoy typing!

    Marked as helpful
    1
  • aryakrishnaksh2021•50
    @aryakrishnaksh2021Submitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    I am able to build a responsive webpage

    What challenges did you encounter, and how did you overcome them?

    I didn't encounter any challenges

    What specific areas of your project would you like help with?

    How can i increase the performance

    Social links profile challenge solution

    1
    David•60
    @Dav1dGPPosted 7 months ago

    Hi aryakrishnaksh2021 !

    Good job completing this challenge !!!!

    Two little things I have to comment:

    First, the media query rules seem to have overlapping ranges. For example, you have one media query for screens between 480px and 371px and another for screens below 370px. But the media query for 480px to 371px would already apply to all screens below 480px, which makes the second media query redundant.

    Notwithstanding the above, for this project it is not necessary to use media queries.

    Finally, if links are expected to redirect to external pages or different parts of the website, it would be more semantic and accessible to use a <nav> element along with the corresponding links.

    I hope these comments help!

    Good luck and enjoy typing!

    0
  • David•60
    @Dav1dGPPosted 7 months ago

    In general, your project is very good.

    Some things that I think could improve your code:

    -Keep consistency in class nomenclature as it makes the code easier to read and maintain.

    -The card img does not have Alt text.

    0
  • David•60
    @Dav1dGPPosted 7 months ago

    Overall I see the design as very good.

    The only thing I would add is that for your site not to be completely inaccessible, do not declare the font-size in pixels, better declare it in rem.

    I leave you a link to an article: https://fedmentor.dev/posts/font-size-px/

    0