@Dartheryon
@tshegofatso-motlhakane
Submitted
What are you most proud of, and what would you do differently next time?
I did the most bruh
What challenges did you encounter, and how did you overcome them?
I was able to make everything fit
What specific areas of your project would you like help with?
Colors and shadows
@Dartheryon
Posted
Hi! I think it was a nice job, mate :D I have some improvement notes for you. the size of elements like the badge and heading text are quite different from the ones on the design. Keep an eye on it :)
regarding your code, I see the image is not rendering on your solution. This happened because in your index.html line 30 you define the route to the image in a wrong way. if you want to use relative paths, in this case you do need a leading dot, before the « / » Besides, you should always use an alternative text for your images. your code:
<img src="/assets/images/image-avatar.webp" alt="">
my suggestion:
<img src="./assets/images/image-avatar.webp" alt="creator avatar">
Accesibility is something important, that many of us leave unattended. I want to change that on myself and it would be nice if you commit to do it as well. :)
Keep moving forward dude!! :D
@P-Mingi
Submitted
What are you most proud of, and what would you do differently next time?
I think that i did a good job, i probably have a problem with the size of my main container, but the rest is fine i think. It shrink well to a smaller size page format.
What challenges did you encounter, and how did you overcome them?
I think the way to make it responsive, i don't know if i used the good method by using a media query, i wished i could do it without using any, but i don't think it was possible.
What specific areas of your project would you like help with?
With my Responsive method, did i did well by using a media query, should i have use it at a higher width, or was there another way to do it ?
@Dartheryon
Posted
I think it is a good work. It could be better if you take a look on the figma file and the meassures defined on it :) Taking a look into your repo, I can see you did not change the readme as the exercise suggest us to. It would be nices if you take the time to makeit, using the readme-template provided, as a guide.
It seems there might be some accesibilites issues you can improve. I refer to landmarks, specially.
You use a h2 tag without using previously a h1 tag. Remember that those tags are not a matter of size, but a semantic important part of the document. Please take a look on it :)
Marked as helpful
