jvodlz• 10
@jvodlz
Submitted
Feedbacks are welcome.
Having used flexbox I had expected elements to be centred but it was a little more difficult than I thought. I'm unsure whether margin: 0 auto was the appropriate fix.
Darren
@DarrenBerg1
All comments
- Darren• 120
@DarrenBerg1
Posted
margin: 0 auto is something that a lot of people use! This is because margin in flexbox is a bit finicky and acts weird. I have linked an article that goes a bit more in depth and explains it better!
Good luck on your future projects! https://css-tricks.com/the-peculiar-magic-of-flexbox-and-auto-margins/
0 - Henry Asante• 220
@Henry33y
Submitted
Darren• 120@DarrenBerg1
Posted
Great solution Henry, I like how you added the animation to the button with the onClick. I enjoy seeing people put their own spin onto the projects, while staying within the original design. I feel like you may be a bit ahead of some of us on here! Good luck with your future projects!
1 - Jon Henrik Åvitsland• 190
@jonhenrikaavitsland
Submitted
Darren• 120@DarrenBerg1
Posted
Your solution looks great Jon! I went to your live site and it looks good there as well, although I did notice that you did not implement any of the hover states. I wont lie and act like I am great, because I could not figure out how to "hover" the image. But, for the text hover you can implement the :hover pseudo-class in CSS. I have linked the MDN below, so you can read up on it if you'd like.
Good luck on your future projects!!
https://developer.mozilla.org/en-US/docs/Web/CSS/:hover
Marked as helpful
0 - ADEYEMO AYOMIDE O.• 340
@femmytedrey
Submitted
Darren• 120@DarrenBerg1
Posted
Hey! I have been stalking your solutions LOL. It seems like you are really drilling down on CSS grid / flexbox. Your solutions are looking great as well, I am envious of your grid skills! That and responsive designs is something I need to work on. Good luck with the coding !!
1 - ADEYEMO AYOMIDE O.• 340
@femmytedrey
Submitted
Darren• 120@DarrenBerg1
Posted
I was looking at your code, and it looks good. Your media queries are setup nice for this project as well, it moves fluidly into mobile. Great Job!
1 - Cameron Chandler• 850
@webstormcam
Submitted
Challenged myself to build this design with Tailwind. I built this project and the one previous with it and I feel a lot more comfortable using it now. Going to continue using it in my projects from this site and others going forward.
Darren• 120@DarrenBerg1
Posted
This looks awesome! I have been seeing more things about Tailwind CSS throughout my LinkedIn and scrolling through projects. It looks very interesting, hope you enjoyed it. Your project looks great and the responsiveness looks good as well (without actually looking at the code). I'd say you knocked this one out the park.
1 - Quincy Bulla• 10
@dominionworkz
Submitted
Hey, fellow Frontend Mentor community, hope all is well. Here's my first project, I feel like a success, with the results, however, it took me a while to code this out. Especially, when I was working on the CSS styling of the HTML.
In looking at the code base, is there anything I could've done better, easier? That's for both HTML and CSS.
You will see in the CSS I have some snippets commented out, this is how I had the code written before the changes in how it is now. What did I miss on the use of that concerning the QR code itself being n a div with a classification?
The other thing I am not sure of is how the CSS is applied to the body tag element, it's currently working, however, is there something I could've done better?
Lastly, does it matter in the CSS whether the properties on the selectors are in alphabetical order, from the viewpoint of specificity?
I look forward to any feedback. Thanks, Q
Darren• 120@DarrenBerg1
Posted
Hey great job on your first project! You did great.
Some things that I would recommend doing is looking into mobile first or "responsive" CSS. _nehal💎 mentioned it as well, as in using em, rem, % and vh all help with increasing responsiveness within your site. This is important more than ever, as people are searching things on their phone rather than a desktop.
again, great job! I will follow you to see you improve, as I do as well!
Marked as helpful
1
