Skip to content
OverviewSolutions
7
Comments
5
Clinton
@DarkFM

All comments

  • Clinton•260
    @DarkFMPosted about 4 years ago

    Looks really well done. I feel the animations add a nice touch to the solution. Some things I've noticed, at widths 992px to 1330px, the hero items in the About and Contact pages have their contents cut off. Another thing is that ad medium to small widths, the same hero items show a vertical scroll bar when there is nothing to scroll.

    But all in all, this is really good work. two thumbs up from me.

    0
  • Giovanni Ranzato•240
    @GiovanniRanzatoSubmitted about 4 years ago

    I started from mobile layout with flex box. When I moved to desktop version I used absolute-relative positioning to place the elements; I'm not sure I did it in the best way possible; can someone give me some advice?

    I added some animations, but I've some issue if someone hammer the buttons. How may I handle buttons hammering?

    Html CSS javascript

    2
    Clinton•260
    @DarkFMPosted about 4 years ago

    Hi Giovanni.

    Good job with the solution. I really like the animations as it is a nice touch. To answer your question on how to handle when the buttons are clicked really fast, you can implement something called debouncing. It is basically adding a delay after each button click and during this time you disable user input.

    You can take a look at this example for more details

    0
  • Clinton•260
    @DarkFMPosted about 4 years ago

    Angular doesn't get a lot of love so its glad to see one in the wild :) I like the solution so far. There are some things i noticed though:

    • The content does not shrink at smaller screen sizes, and overflows the view-port. You can use media queries to solve this.
    • The country cards are don't have any indication that they are clickable. You can use a cursor: pointer in the CSS. Its good for user experience.
    0
  • Clinton•260
    @DarkFMPosted about 4 years ago

    @AhmedXGoda Really well done my man. I'm loving the page transitions. I also liked that you mixed old school class based react components with functional ones. Keep it up.

    1
  • Clinton•260
    @DarkFMPosted about 4 years ago

    Love the animation :) well done

    1