Decided to do an easier challenge since I'm learning Node on the side and needed more time for it and di not want to break my GitHub green box streak, lol. Please let me know what you think, and any thoughts are always welcome.
Hamid Tahir
@DarkAmdHaAll comments
- @DarkAmdHaSubmitted over 3 years ago@DarkAmdHaPosted over 3 years ago
Thanks Dusan.
I completly forgot about the buttons, will definetely fix that. Thanks alot for the feedback.
0 - @Barna-MolnarSubmitted over 3 years ago
Pls let me know what do you think about it. Do someone have any idea why does not work the screenShoot properly ? Thanks
@DarkAmdHaPosted over 3 years agoHey! No clue why the slider didn't load, had the same problem. But you should probably add an event listener on the toggler, so that when toggled, the 25% discount is applied to the price.
Marked as helpful0 - @iulian-cenusaSubmitted over 3 years ago
The project is mostly complete but I have some things that I could not done as in design files:
- On the slider thumb in the design files, there are different cursors on hover and thumb grabbing. I put
cursor: grabbing;
property on it and works for grabbing but on hover it did nothing. Can someone help me with this ? - For the background of the slider I used
linear-gradient
and changed it from JS but it doesn't look so good. Could someone give any advice on how to build it better ?
If someone could help me with the questions above or with general advice on how good I used margins, padding and positioning it would be great. Any other feedback is appreciated !
@DarkAmdHaPosted over 3 years agoHey, awesome job here. You can use the
cursor:grab
. You should set the cursor tograb
in the hover state and tograbbing
in the active state of the slider..slider:hover{ cursor:grab;}
and.slider:active{ cursor:grabbing;}
Happy Coding :-)Marked as helpful1 - On the slider thumb in the design files, there are different cursors on hover and thumb grabbing. I put