Skip to content
OverviewSolutions
11
Comments
2
Danilo Mereles
@DaniloMereles

All comments

  • Daryl Carr•70
    @daryl-cSubmitted almost 4 years ago

    Hi!

    I've used 11ty together with Andy Bell's CUBE CSS approach. I've been a general developer for a while now but I really want to improve my core frontend skills so any advice would be greatly appreciated. Anything from the structure of the CSS, refactoring templates, improving accessibility etc would be warmly welcomed :)

    One thing I would like to look at more is some of the animations/transitions for the nav opening/directors boxes toggling/the form submitting.

    Another thing that was a little difficult was going back to using vanilla js for the validation stuff instead of react. Not sure if my approach is very well structured but it seems to work at least.

    Thanks in advance for any input!

    Daryl

    Mobile first using Eleventy and Sass (with a CUBE CSS -ish) approach

    5
    Danilo Mereles•215
    @DaniloMerelesPosted almost 4 years ago

    Hi Dary, the work you did is great: D, but you should add a transition to the menu and remove the hover state from the hamburger button since there is no such state on mobiles and it only consumes resources. (My English is basic, if I misspelled sorry haha)

    0
  • Danilo Mereles•215
    @DaniloMerelesPosted almost 4 years ago

    Good work :D

    1