@DaniSalermiSubmitted over 4 years ago
Hi guys this is my first complete challenge. I hope you like it. I'm excited about hear your recommendations and constructive criticism.
Daniel Sepulveda
@DanielSepulvedaAll comments
- @DanielSepulvedaPosted over 4 years ago
It looks great! Although I would suggest in taking advantage of html5 form validation, and in displaying dynamic error messages, instead of just having the error hardcoded in a hidden element. Keep it up! 👏🏻
0 - @rafagavi44Submitted over 4 years ago
it is my first exercise, any advice, recommendation or suggestion
@DanielSepulvedaPosted over 4 years agoYour solution looks quite nice! I believe you used some BEM guidelines for your css file, that's great! I would recommend this guide for flexbox if you haven't checked it out https://css-tricks.com/snippets/css/a-guide-to-flexbox/. And some suggestions would be to deploy your page with zeit and/or to use some css pre-processors like sass.
4 - @Gursimran07316Submitted over 4 years ago
any sugggestion is appeerciated
@DanielSepulvedaPosted over 4 years agoHey, good solution! Although I would recommend on using a form element for the input instead of a div
0
