@SatyaaamSubmitted over 1 year ago
Please Rate it out of 5 .
Daniel šØāš»
@Daniel-BilodidAll comments
- @Daniel-BilodidPosted over 1 year ago
Hi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About hr
You can change your hr to div to make it smaller and decrease the opacity to make it less contrast
try to do like this
<div class="hr-div" style=" margin-top: 20px; width: 348px; height: 1px; background-color: black; opacity: 0.2; "></div>I hope it was helpful, you are great, keep up the good work š
Marked as helpful1 - @JoDeppSubmitted over 1 year ago
-I ended up removing the footer for the desktop version b/c I couldn't get it to the correct position... :/ -Many things I can improve I know, but I am taking a break from this project. -I'm confused about the difference between Grid and Flexbox, and when to use which. Can I use them both in the same website? I gravitate towards Flexbox because I know a little bit about it.
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About grid and flexbox
You can use them both in the project
And if we talking about grid its more convenient with making a list of smth or if u wanna create a tab list
checkout this article
I hope it was helpful, you are great, keep up the good work š
Marked as helpful0 - @nadun-dhananjayaSubmitted over 1 year ago
Hello, everyone! I just completed the Product preview card component solution challenge.š š¤©
Any feedback and suggestions will be appreciated. Thanks : ).
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About border-radius
you can add a border-radius like this
.card { border-radius: 5%; }and for the img
.product-image { border-radius: 5%; }š¹ You need to put a landmark in your code
simply wrap your code with <main class='card'> landmark instead of <div class='card'>
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
Marked as helpful1 - @zareenf01Submitted over 1 year ago
Completed this interactive rating component using html, css and js. Practiced DOM manipulation and event handling.
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About margin-top
You can set
<div class='rating'>to
.rating { margin-top: 100px; }it will help you to center your element
š¹ You need to put a landmark in your code
simply wrap your code with <main class='rating'> landmark instead of <div class='rating'>
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
0 - @ShnawMustySubmitted over 1 year ago
These small icons don't want to show , don't know why :'(
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About icons
Try to change your path like this
<img src="../assets/images/icon-memory.svg"/>or
<img src="../../assets/images/icon-memory.svg"/>š¹ And you need to add an alt tag to your images
š The alt attribute contains a textual description of the image, which is optional but incredibly useful for accessibility
I hope it was helpful, you are great, keep up the good work š
0 - @WioletaMenSubmitted over 1 year ago
All feedbacks are welcome, thank you.
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ You need to add an alt tag to your images
š The alt attribute contains a textual description of the image, which is optional but incredibly useful for accessibility
I hope it was helpful, you are great, keep up the good work š
0 - @hadassah123Submitted over 1 year ago
I had a bit of difficulty centralizing my work
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ You need to put a landmark in your code
simply wrap your code with <main> landmark
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
0 - @dev-unicitySubmitted over 1 year ago
my first Frontend mentor challenge.. corrections is highly welcome.
what do you think I need to improve on?
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About text
You can add a width to the h3 and p text to compress it
š¹ About background
You can add a width of 100vw and a height of 100vh, check this article
I hope it was helpful, you are great, keep up the good work š
0 - @ntandomaganaSubmitted over 1 year ago
Any feedback is welcome - this is my second solution as my first one had errors
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About bages/images
You can put a z-index and make a picture on top of everything check this article
š¹ You need to put a landmark in your code
simply wrap your code with <main> landmark
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
Marked as helpful0 - @Dikachi-ScorpioSubmitted over 1 year ago
am new to coding so far I have only been able to learn html and css I made the web page mobile responsive but I do not think my method would work across all devices. I would appreciate it if my work is looked into by the senior developers. Thanks
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ About responsive design
You can open a developer console and check if everything is okay, also i recommend you look at this article
š¹ You need to put a landmark in your code
simply wrap your code with <main> landmark instead of <section class="main">
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
0 - @Pio678Submitted over 1 year ago
What I learned
- how to import fonts using @import
- how to swap images between mobile and desktop version using tag
- how to use rem and em units in css
Feedback welcome
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ You need to put a landmark in your code
simply wrap your code with <main class='product-previev-container'> landmark instead of <section class='container'>
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
Marked as helpful1 - @codaroseSubmitted over 1 year ago
I still don't know all of the best practices for accessibility and SEO. I hope to improve my coding ability with regard to those areas especially.
@Daniel-BilodidPosted over 1 year agoHi, my congratulations you did a great job š
ššØš¦š šš¢š©š¬ ššØš« š²šØš®š« ššØšš š
š¹ You need to put a landmark in your code
simply wrap your code with <main> landmark
š The <main> HTML element is intended for the main content (content) of the <body> of the document (page).
I hope it was helpful, you are great, keep up the good work š
0
