Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @l3miage-bouvier5

    Submitted

    Hello ! If somebody can answer those questions i would be glad:

    • I struggled a with the shadow, is there a tip to manage them better ?

    • As you can see, my card is not exactly in the middle of the page, i don't know how to do it...

    • Do me code respects clean code conventions ?

    Thanks a lot (I am french sorry if my english is terrible)

    P
    DBan3 70

    @DBan3

    Posted

    Hi, I am also new to Front-End but I can maybe help.

    The shadow is fine, I've been doing it that way too.

    Card in the middle issue: try expanding body to the full height of the screen and then centering should work I think.

    Also the code is readable and clean.

    Marked as helpful

    0
  • @Ashok-Kumar-dharanikota

    Submitted

    Taking on this challenge really helped me figure out grid layouts better. It was cool, but I had a problem. I couldn't make the text show up on top of the "bg-pattern-quotation" image. I tried using z-index and absolute positioning, but it didn't work like I thought it would.

    Also, some testimonials had empty spaces. I guess it's to make them all the same height, but is there a better way to do that?

    If anyone tackled this challenge and has some solutions, I'm super excited to see them. It'll help me learn some good tricks.

    Thanks a bunch!

    P
    DBan3 70

    @DBan3

    Posted

    Very nicely done! As for empty spaces, you could utilise "line-height" property to space out rows in text so they fill up more vertical space. Or perhaps make the right column a bit skinnier so it doesn't have so much space for text. It will then push the text in a more vertical position.

    I'll try this challenge out, look out for it on my profile in a day or so if You're interested.

    I am a beginner myself, but if You have more questions feel free to ask.

    1
  • P
    DBan3 70

    @DBan3

    Submitted

    Currently it really works only in the two views, Desktop - 1440p and Mobile - 375p. I will try to make it more responsive, if anyone has any good tips I will gladly accept.

    P
    DBan3 70

    @DBan3

    Posted

    I should've done it with div's instead of span I guess that would be better

    0