Skip to content
OverviewSolutions
13
Comments
5
Tomasz
@CurseTommy

All comments

  • Tomasz•240
    @CurseTommyPosted about 2 years ago

    Hi @Drougnov 👋, good job completing this challenge! 🥳

    Your side and code looks perfect, good hover transition, and awesome hamburger menu buttons.

    Overall good job, and keep it up 😁👋

    1
  • Tomasz•240
    @CurseTommyPosted about 2 years ago

    ** Hi @NabilWasir 👋, good job completing this challenge! 🥳**

    Code looks good to me.

    I give you two tips how to improve your code for future:

    1.Use vh and vw instead of px as comes to width: and height: of the tag --> More about vh and vw in Webflow

    2.Use semantic HTML structure --> Semantic HTML

    Good luck in future, enjoy coding 😁👋

    0
  • iulias17•210
    @iulias17Submitted about 2 years ago

    Any feedback is highly appreciated! I feel like the HTML and CSS is very messy so I'll try to work more on making it look cleaner. I had a hard time with the overlay icon. It looks ok, but I wonder if there is an easier way to do it!

    Thanks!

    Responsive NFT Preview card component using HTML & CSS

    1
    Tomasz•240
    @CurseTommyPosted about 2 years ago

    Hi @iulias17 👋, good job completing this challenge! 🥳

    1.First you need using alternate text --> alt='' in your <img> tag. It helps when your illustration will not load on the side. Instead of it, will appear your text, mostly it's just description what does image shows.

    2.Second, use rem or % rather that px.

    3.I saw you're using hsl color code with is very good. Because you can easily manipulate color shade.😄

    4.When you're styling with position: absolute; there is no reason to use both top: 0;, bottom: 0;, same situation with left: 0; and right: 0;. Simply use only top: 0;, left: 0;. Overlay is made good, but you could add transition-duration: 600ms; for better look.

    Good luck in future, enjoy coding 😁👋

    Marked as helpful
    0
  • Tomasz•240
    @CurseTommyPosted about 2 years ago

    Hi!

    I recognize one think that could have been done better, it's section class names, you must be more specific in terms of class names. Because one two three doesn't mean much, take a look as a person who trying to review code, how they can know what this name means.

    Also order is done good Another thing is responsive design, if you want to make it easier try to use units like :

    1. rem, em
    2. vh, vw

    Those are reacting to side width and height

    And you can use clamp() as well, more about --> clamp()

    Good luck in future. Keep it up 😁

    0
  • Tomasz•240
    @CurseTommyPosted about 2 years ago

    Hi!

    Responding to your question, you should write CSS or SASS then using Bootstrap. Bootstrap will not teach you CSS, it's just unnecessary shortcut.

    For example by using CSS libraries you're just adding classes but by writing your own CSS you adjust them and have a great time messing around them.

    Good luck in future :)

    Marked as helpful
    1