Skip to content
OverviewSolutions
16
Comments
20
Liam R
@Cooly-o-Cats

All comments

  • Shawn•20
    @skscjoynerSubmitted about 2 years ago

    I had fun with this project. I did find the overlay a little challenging...and a learning experience. Please offer any related feedback for improvement.

    NFT Preview Card

    2
    Liam R•425
    @Cooly-o-CatsPosted about 2 years ago

    This is great! It seems that the card doesn't shrink on mobile. Anything under 375px. It would be great if you solved this, probably easiest using media queries.

    1
  • Liam R•425
    @Cooly-o-CatsPosted over 2 years ago

    This solution looks great! Make sure to use the font provided in the design file to keep the site looking as close to the design as possible. Also, I noticed your spacing seems a little off especially at the "We're Different" section. Finally, make sure to put your HTML in either <header>, <main> or <footer> tags. That will fix your accessibility issues.

    0
  • Liam R•425
    @Cooly-o-CatsPosted over 2 years ago

    Personally, I think that the site looks great and is very responsive. Be sure to keep all HTML elements inside either <header>, <main> or <footer> tags. That will fix your accessibility issues.

    Marked as helpful
    0
  • Adam Elitzur•110
    @AdamElitzurSubmitted over 2 years ago

    Is there anything I should be doing differently? I use flexbox a lot, is there a better way I should be centering things? (Like the eye icon when you hover over the image, and the price and ETH icon and time and clock icon) Thanks!

    NFT Card with CSS (flexbox)

    2
    Liam R•425
    @Cooly-o-CatsPosted over 2 years ago

    This solution is great! Flexbox seems to be the right way to go in most of these situations for the design. The only thing I would change is giving the card a margin between the top and bottom of the screen!

    Marked as helpful
    1
  • Matheus Santos•50
    @matheussantoswsSubmitted about 3 years ago

    Muito legal esse desafio. Bem basico de se fazer usando margin e padding da para fazer tranquilo

    HTML CSS

    1
    Liam R•425
    @Cooly-o-CatsPosted about 3 years ago

    ! Traduzido pelo google |! Parece ótimo, e a capacidade de resposta também é ótima. Eu sugiro colocar uma largura máxima no texto do tablet. Isso só vai fazer com que pareça mais limpo!

    0
  • Liam R•425
    @Cooly-o-CatsPosted about 3 years ago

    ! | Este mensaje es traducido por google | ! ¡Gran trabajo! Parece increíble. ¿Quizás intentar arreglar un poco más tu logo? Se coloca en posiciones extrañas con demasiada frecuencia.

    Marked as helpful
    0
  • Liam R•425
    @Cooly-o-CatsPosted about 3 years ago

    Nice! Seems like some of the styles are off. Check the design and try a little bit harder! Mainly some fonts and sizes are off.

    Marked as helpful
    1
  • Liam R•425
    @Cooly-o-CatsPosted about 3 years ago

    Great Job! Here are some suggestions. Overall the Card seems quite big on all sizes, The spacing between the card and the edges is too small most of the time.

    Marked as helpful
    0
  • VladimirBrscic•775
    @VladimirBrscicSubmitted about 3 years ago

    Hello, I did not try to do layout using flex as much as possible. For such a simple page I found it easier to just use some margins here and there. Hope it's alright done this way. Any opinions appreciated! Thanks.

    responsive mobile first ping coming soon page

    1
    Liam R•425
    @Cooly-o-CatsPosted about 3 years ago

    Great Job on Responsiveness!

    Marked as helpful
    0
  • Liam R•425
    @Cooly-o-CatsPosted about 3 years ago

    Hmm, The design seems a little off with spacing. I'll fix that soon!

    0
  • Mitchell Gould•250
    @helphopSubmitted over 3 years ago

    I tried to make the code as clear as possible. I also went through many iterations and refactoring to use components to reduce the amount of code I wrote.

    If you know of some tricks or better ways of coding things I would be very appreciative of your feedback.

    Grid Flexbox Javascript and a bit of Codyhouse Framework

    6
    Liam R•425
    @Cooly-o-CatsPosted over 3 years ago

    Awesome Job! One critique I have is that when I hover over the team's photos, the gray overlay tends to flicker. Not sure how to fix it, but just saw it as a bug. Anyways great work!

    0
  • Liam R•425
    @Cooly-o-CatsPosted over 3 years ago

    Great Work! Few Suggestions: 1 - Reduce the white space at the top to allow it to be close to the design. 2 - In the design, there is a state and a message when input fields are blank, Could you do this?

    1