Frontend Mentor | Conrad's profile

@spencerrundeSubmitted about 3 years ago

Decided to do this without Javascript to complete the optional challenge in the description. Also added the animation of the box bobbing up and down just for fun.

CSS only FAQ accordion

2

Conrad•950

@ConradMcGrifterPosted about 3 years ago

nice job completing the optional challenge 👍

I only see one issue:

if all the accordion tabs are opened, the content overflows the card (this is because you have a fixed height set on your card)

Marked as helpful

1

Brooke Wargnier•155

@brookewargnierSubmitted about 3 years ago

This was a quick 4 hour evening build. It really helped me start to feel like I'm getting a good handle on CSS and HTML, and it felt especially nice after my last project which had multiple section on a page!

Please let me know if you find any issues of standards or any additional resources that you think will help me grow in any capacity :)

Thanks!!

Brooke

Mobile first solution using HTML and CSS

1

Conrad•950

@ConradMcGrifterPosted about 3 years ago

good job, it looks really nice 👍. I am also doing some smaller projects after completing some of the longer/bigger ones and I think its a good way to try new things!

my main suggestion is that you should avoid setting fixed height and width, especially fixed heights because this can cause problems with responsiveness and content overflowing its container.
if you really need to set a width or a height, use min-height:, max-height:, or min-width:, max-width:
try and use margin and padding on your elements inside the cards to create the space you need instead of setting a fixed height

Marked as helpful

1

Ahmed Sameh•60

@Ahmed0107Submitted about 3 years ago

Can you rate this work, please?

HTML, CSS and JavaScript

2

Conrad•950

@ConradMcGrifterPosted about 3 years ago

its pretty decent. I would rate it 7.5/10

I think you need to fix the layout on mobile
on desktop at larger resolutions your design is stretching so try putting a max width on your div container
I think you need to validate the password better because currently you can enter just 1 character and it will accept it. maybe put a length requirement

Marked as helpful

1

Mohamed Draz•80

@mohameddrazSubmitted about 3 years ago

what is my grade?

HTML & Css

1

Conrad•950

@ConradMcGrifterPosted about 3 years ago

you are using way too many grid columns / rows. 135 is a pretty ridiculous number.
your grid is not responsive and the text is overflowing the containers. Try to use a responsive unit like fr to set the grid colums / rows.

Marked as helpful

0

Abdullah Nadeem•20

@abdnadeem382Submitted about 3 years ago

Any feedback on grid systems or underlining links will be highly appreciated.

Loopstudios challenge completed with responsiveness. No bootstrap.

2

Conrad•950

@ConradMcGrifterPosted about 3 years ago

here is a codepen I made to show you how I did the underline hover effect for my project

Link to codepen

Marked as helpful

0

Shiro•80

@shironeko2707Submitted about 3 years ago

Hi. This is my lastest project on FrontEnd Mentor. Any feedback is appreciated

Stats review card component using html and css

1

Conrad•950

@ConradMcGrifterPosted about 3 years ago

your image isnt showing up because you need to add the src="./images/image-header-desktop.jpg" on the image element.

example: <img class="img-src img-mono" src="./images/image-header-desktop.jpg" alt="">
currently you are trying to use the property content: url("./images/image-header-desktop.jpg") to link the image but that is not correct

0

Danilo Alves 🎧•535

@mizek1Submitted about 3 years ago

Hey! It's the first time I use BEM methodology. What did I miss? Any tips and feedback would be absolutely appreciated.

Profile card component with BEM methodology

2

Conrad•950

@ConradMcGrifterPosted about 3 years ago

looks good to me, nice job 👍

1

Stephane Jean•360

@distephano30Submitted about 3 years ago

Greetings,

Let me know what you think

Four card challenge with HTML and CSS

2

Conrad•950

@ConradMcGrifterPosted about 3 years ago

well done, the site looks good to me. The only thing I would suggest is that you put a max-width on your main container so that it doesn't stretch out at bigger screen sizes

Marked as helpful

0

César Mejias•190

@CesarGMEFASubmitted about 3 years ago

I hope advice, criticism and whatever.

I had serious problems with the height of the cards and well I think everything is fine.

testimonials complete by Cesar Gabriel

1

Conrad•950

@ConradMcGrifterPosted about 3 years ago

good job , Cesar

I would put a max-width on your main container so that it does not stretch at larger screen sizes

Marked as helpful

1

Diego•180

@Diego-Garza2007Submitted about 3 years ago

Creo que el codigo que escribi es un poco desordenado aun estoy aprendiendo si ven en algo que pueda mejorar comenten

Html Css

1

Conrad•950

@ConradMcGrifterPosted about 3 years ago

you should avoid putting a fixed height on your containers because this could cause problems with content overflowing

debe evitar poniendo un altura fija en su cajas, porque no es responsivo. debe usar min-height in vez de height en la mayoría de los casos.

Marked as helpful

1

Branden Evans•20

@BrandenEvansWDSubmitted about 3 years ago

I would appreciate any feedback! I'm very new to scss still. One of the issues I was having was using "@use" to import my partials into my main scss style sheet. I eventually was able to more it work using @import and I can't seem to figure it out. Also issues with vs code plugins crashing whenever I would open the style.scss file.