@John-CSM-TateSubmitted over 2 years ago
What is best practice with landmark tags? (Do you use them like a div containers)
Colin McArthur
@ColinMcArthur85All comments
- @ColinMcArthur85Posted over 2 years ago
Hey John
Just wanted to say good job with this solution! Your solution looked pretty much spot on to what mine looked like once I uploaded it. One thing I noticed was that your file management in your repository was much cleaner than mine was and that you included a README.md and some screenshots with your project so I wanted to say thank you for letting me poke around for some best practices.
One other thing I noticed. I see that you had an accessibility report on your project - https://www.frontendmentor.io/solutions/responsive-qr-code-component-GZoQQjIB4/report, I had the exact same thing and it was because there was no <h1> tag in the project. I just jumped to using an <h2> on the title of the card, which it looks like you have done as well. Just change that <h2> to an <h1> and update the solution and that error will go away.
Cheers!
0
