Skip to content
OverviewSolutions
21
Comments
5
clinton wambugu
@Clinton-dev

All comments

  • clinton wambugu•455
    @Clinton-devPosted 9 months ago

    Nice work love the implementation, just a minor suggestion to add on user experience- to close the cart card when user clicks outside otherwise one has to refresh the page to remove it

    0
  • clinton wambugu•455
    @Clinton-devPosted 11 months ago

    Just a to point a minor suggestion: you can add margin-top-right to results div. Other than that your design on both desktop and mobile look clean, Keep up!

    Marked as helpful
    0
  • enochlee•600
    @iamenochleeSubmitted about 2 years ago

    My very first react project, completed this a week ago just didn,t submit made use of the json file.

    Expenses Chart

    1
    clinton wambugu•455
    @Clinton-devPosted about 2 years ago

    Hi @iamenochlee great job on creating the app to be as similar to the design. Suggestions:

    1. You could add some margin on both the top and bottom of the page.
    2. Add some margin on the sides both left and right on mobile screens.
    3. Add more details (link to active sites, technologies used etc)in description section of your readme
    Marked as helpful
    0
  • clinton wambugu•455
    @Clinton-devPosted over 2 years ago

    I found app doesn't display well when viewed from a mobile end but looks great design on a desktop . You could also customize your readme to include the tech used where you got stuck , instead of having the default one that frontend mentor provides.

    0
  • clinton wambugu•455
    @Clinton-devPosted almost 4 years ago

    The illustration box desktop isn't at the correct position, you can try transferring it to .box-image container as illustration-box is positioned relative to the nearest positioned ancestor

    1