I found it fun and challenging to get all the animations for the mobile menu and hamburger to work properly. Had some small issues with getting typography to match up perfectly, if anyone has tips on how to get line height/letter spacing to match up perfectly without the design files it would be good to hear. Any other suggestions/comments are also welcome!
ClaudiuManuel
@ClaudiuManuelAll comments
- @sjohnston82Submitted about 1 year ago@ClaudiuManuelPosted about 1 year ago
Hello,
First and foremost good job! You nailed it!
One thing I might change is that whenever a user clicks one of the dropdowns I'd actually close all the other ones that were opened before. It's kinda weird to have 2 dropdowns opened at the same time. Moreover, your dropdown section modifies its width when I hover over a longer value (ex reminders or our team).
Hope this helps!
1 - @andaluciacurtisSubmitted about 1 year ago
Is there an easier way to calculate the date? I did it the long way, but I'm wondering if there are any methods from the Date object to utilize.
@ClaudiuManuelPosted about 1 year agoYou might want to change the read me file to fit your project.
Also, I would remove unnecessary comments in the code, for example RESET FUNCTIONS in the script file. They don't provide anything useful. You could tell immediately that the function is supposed to reset something from its name.
You do have some good comments that are needed IMHO (those explaining the complicated calculations you're doing to figure out the days/months etc.)
Design is looking solid! Good job!
0 - @KrishnaVishwakarma1595Submitted about 1 year ago
Hello, Mentors
My responsive solution for this challenge with some tweaks considering users' UI/UX experience.
My Learning
- Writing semantic HTML5 markup with HTML accessibility
- Working with CSS Grid/Flexbox
- Mobile/Desktop first workflow
- Bootstrap CSS Framework
- Form Validation & Handling
- Javascript DOM Manipulation
- Javascript OOPS Concepts
What users can do
- View the optimal layout for the app depending on their device's screen size
- See hover states for all interactive elements on the page
- Calculate the correct tip and total cost of the bill per person
@ClaudiuManuelPosted about 1 year agoHello,
At a very first glance I saw that you still have some commented code in the css file. Another thing I noticed is that when you click to enter a custom tip amount you're forced to click a second time on the field in order to have it focused. I would do it automatically if the user already clicked custom.
Other than that, the solution looks great. Good job!
Marked as helpful1