All comments

• 

  Ken_1219•50

  @Ken-1219Submitted over 1 year ago

  This is my first submission after joining Frontend Mentor so I don't know if I properly implemented the challenge or not. So, I would appreciate any feedbacks and suggestions given. Thank You!

  

  QR Code Component using CSS Flex

  2

  40
  

  P

  Celie987•40

  @Celie987Posted over 1 year ago

  Great job !

  I have just finished it too. So I am maybe not the best one to provide advice.

  For me, when I have solved the challenge I have tried to avoid the usage of the <div> tag for using html semantic ones instead : e.g. For storing the QR Code I have used a <picture> tag instead of <div> t

  For this one I have not made a distinction between the mobile and desktop version as it didn't changed, so I have not used @media query. But I think that in the @media query we need to try to only get the tags or css styles pieces which are modifed. So all the elements which are identical for both version remain outside of the media query.

  Marked as helpful

  1

  This comment has received 1 replyShow