youssef• 90
@pr0G-alt
Submitted
Carlos Ojeda Avendaño
@Carl-code
All comments
@Carl-code
Posted
Hello @pr0G-alt, Good job, just a few details there like the height of the card and the rest, everything is fine, also if you consider the names of your classes, it would be a plus. It's great that you have the colors as variables in :root, that shows that you are doing things right. As a last point, take into account semantics, it may be good, but I think that more specificity would be great.
0- Corvida Raven• 680
@SheGeeks
Submitted
What are you most proud of, and what would you do differently next time?
This is a great challenge to help anyone improve their knowledge of CSS functions like
clamp()to create simple and responsive layouts.@Carl-code
Posted
Hello friend, I just saw your project and code, the project is very good, only that you first did desktop fist, preferably I do mobile first, it is what was recommended, in your CSS code you should use custom properties which is using the colors in the :root Just like in the naming of your classes, they should be a little more specific in terms of the elements or components, I hope my feedback is useful to you.
1 - parag patil• 10
@covert-bot
Submitted
What are you most proud of, and what would you do differently next time?
i am proud that i made card's design as close as prototype given
What challenges did you encounter, and how did you overcome them?
alingning the item was little bit challenging
What specific areas of your project would you like help with?
improving my css skills
@Carl-code
Posted
Hello buddy, good job, there are some points to highlight about your project which are the following, I hope to be constructive enough for your growth:
- You need to put your code semantically as HTML5 uses it.
- Your CSS code should be in another file called styles or something like that in a different folder called css. 3.You must use CSS Flexbox for this project. A video on YouTube would be enough to learn how to use it and it would improve your developments.
0
