Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @srplanta

    Submitted

    What are you most proud of, and what would you do differently next time?

    Most proudly things are using css variables, resetting body environment and implementing media query.

    What challenges did you encounter, and how did you overcome them?

    Ready & following figma file was a bit tedious.

    What specific areas of your project would you like help with?

    Most of the task I achieved myself.

    @CamilleClinchamp

    Posted

    Very good! Some sizes and margins are not very accurate. Your HTML code could be simplified too, but that's all.

    0
  • @shaik-zakir

    Submitted

    What are you most proud of, and what would you do differently next time?

    I have used Bootstrap to achieve the solution.

    @CamilleClinchamp

    Posted

    Your solution is pretty good, just a few things I have noticed:

    • Instead of using div elements, you could have used semantic tags for better accessibility (<article> for the card for example)
    • You didn't have to wrap your card inside <div class="set-card-center">. The CSS properties of this class could have been added directly to the body.
    • The image itself didn't have to be a flexbox. Just using a text-align: center on the card would have centered all the elements inside of it.
    • Your card-body class doesn't have any CSS attributes, meaning this div probably isn't necessary at all. Just put the text inside the card, along with the image. To keep those texts under the image, add this line on your flexbox (body if you follow my advice, set-card-center otherwise): flex-direction: column;

    Your result respects the design, which is already excellent! I'm just giving some advice to improve the quality of your code.

    0