@andzz-zzSubmitted 9 months ago
I used HTML and CSS to create this project. I feel like my code is too long any suggestions on what I can remove/replace? Also would like feedback on responsiveness :)
Your feedback is much appreciated!!
CairoGarb
@CairoGarbAll comments
- @CairoGarbPosted 9 months ago
It looks great! The responsiveness works well. About the code, you can remove the repetitiveness in the "@media screen". You can set all the changes you want in only one (if they are the same).
EX: @media screen and (min-width: 300px) and (max-width: 780px) { // major changes }
Marked as helpful0 - @TrenyceCodesSubmitted 9 months ago
Goodmorning Frontend Community
I just finished a challenge between yesterday and today. It has been a while since I have been on this site and quite frankly I need to brush up on my basic coding skills.
I completed this challenge and so far the only problem I faced so far, is my image not showing up. If you have any advice or criticism on what I can do better, let me know.
Happy Coding!
@CairoGarbPosted 9 months agoWell done! For the img, change the url to "images/avatar-jessica.jpeg" or "/images/avatar-jessica.jpeg". The 'images' folder is already inside the 'project' folder, so changing this would work.
Marked as helpful1 - @SalmaW03Submitted 9 months ago
Hello, I finished the QR code challenge but I feel like the white background with the class (.bg) could have been done in a better way. I would like to know what you all think?
@CairoGarbPosted 9 months agoHey! Regardings of the .bg, maybe using display: flex. The measures "rem" or "pixels" instead of "%" could improve it. Flex would improve the alignment of the division, not needing to manually center the main container on the center of the page. I noticed that you used "position: absolute" on the image, maybe if you change the width of img to 100%, remove the absolute position and the margin left and in the "h2", remove the margin top aswell. Was well done, good job!
Marked as helpful0
