Skip to content
OverviewSolutions
23
Comments
3
P
CJ Cameron
@CJCameron13

All comments

  • W3RKY•70
    @xAnDrOm3dAxSubmitted 6 months ago
    What are you most proud of, and what would you do differently next time?

    I thought my design was true to the original and I am very proud of the responsive css that was implemented.

    What challenges did you encounter, and how did you overcome them?

    The most challenging part for me was trying to figure out which components need to be developed seperate from each other, and ho to hide and introduce them once the email was validated.

    What specific areas of your project would you like help with?

    If anything, I would like feedback on my javascript. However, all feedback is welcomed.

    Newsletter sign-up form with success message - HTML, CSS & Javascript

    1
    CJ Cameron•350
    @CJCameron13Posted 6 months ago

    Hello! I really like your solution. I don't have specific feedback as much as I have a question. Can you help me understand the "emailRegex" variable in your main Javascript file? Is it being used to check for certain characters, character combinations etc?

    const emailRegex = /^[^\s@]+@[^\s@]+\.[^\s@]+$/;

    Thank you!

    0
  • Jarrod Ver Hey•150
    @jvisme1991Submitted 7 months ago
    What are you most proud of, and what would you do differently next time?

    I am most proud of completing my first challenge that included using javascript.

    What challenges did you encounter, and how did you overcome them?

    Using js without knowing any of the fundamentals was a nightmare. I will definitely work more with js to gain a better familiarity with it for future use.

    What specific areas of your project would you like help with?

    I would most definitely like more help with js.

    Article Preview Component

    1
    CJ Cameron•350
    @CJCameron13Posted 7 months ago

    Nice work! Another approach you could use is the classList.toggle feature to achieve the same functionality that you currently have. I like to add a class called 'hidden' to the element and in my CSS document, given .hidden the attribute of display:none.

    .hidden {
display: none; 
}

    Using your shareButton and shareLinks identifier, the JS code would look something like this...

    shareButton.addEventListener('click', () => {
shareLinks.classList.toggle('hidden')
}

Now the 'hidden" class will toggle on and off with each click by the user.

Just my preferred method. Well done with the project!
    Marked as helpful
    0
  • CJ Cameron•350
    @CJCameron13Submitted almost 2 years ago

    Overall very pleased with how this came out. The hamburger menu is purely CSS. The transition from the "X" back to the hamburger is a bit funky, I'd appreciate any suggestions for how to fix that. And of course any feedback on what I could have done better. Thanks!

    News Homepage

    1
    CJ Cameron•350
    @CJCameron13Posted almost 2 years ago

    Update: I'm not sure what happened to my menu in the desktop version. I will work on rectifying that.

    0