Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

All comments

  • @jjdavenport

    Submitted

    What are you most proud of, and what would you do differently next time?

    I built the site mobile first and would do the same next time, the mobile menu was interesting to learn.

    What challenges did you encounter, and how did you overcome them?

    The main challange was the desktop layout with grid, I still have difficulty getting it to fit on smaller viewports without overflow.

    What specific areas of your project would you like help with?

    Mainly any feedback regarding accessibility and semantic html, also how to make my desktop layout fit on smaller viewports without overflow.

    P
    BillRozy 170

    @BillRozy

    Posted

    Nice job, I tried to go through your solution using keyboard and it works fine, the only one thing i noticed is that if dropdown menu is open, focus still can go out of it. I had the same issue and solved it using quite new html property "inert". Check it here: https://caniuse.com/mdn-api_htmlelement_inert

    Marked as helpful

    1
  • P
    BillRozy 170

    @BillRozy

    Posted

    Nice job, i see differences in padding, but functionality is very similar

    0
  • caner404 280

    @caner404

    Submitted

    What are you most proud of, and what would you do differently next time?

    In This challenge i tried to implement the accordion component with the compound Pattern.

    What challenges did you encounter, and how did you overcome them?

    Understanding the compound Pattern and it's benefits

    What specific areas of your project would you like help with?

    all critic is welcome

    P
    BillRozy 170

    @BillRozy

    Posted

    Several things i noticed here:

    1. Obviously paddings, font-size / weight and position of widget are not the same as in design
    2. I checked that navigation with a keybord does work, but i think there is no need to make both link and icon navigatable, they should be one group
    3. First accordeon should be open by default
    0
  • P

    @SabaMarghania1

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm proud of taking the first step toward improving my coding skills. It's exciting to dive into challenging problems and see my progress over time. Additionally, I'm proud of setting a clear goal for myself: reaching the top position in coding competitions.

    What challenges did you encounter, and how did you overcome them?

    i only have warning for accesebility

    What specific areas of your project would you like help with?

    with accesebility i didn't understand what is a problem and what i can add into html lang= en

    P
    BillRozy 170

    @BillRozy

    Posted

    color of button is not the same, and I would say color of rating buttons are not the same as well, all the other stuff is very similar, thanks!

    Marked as helpful

    1
  • @anhoang241998

    Submitted

    Hello everyone, I had just finished the challenge. I would appreciate any tips and recommendations on how to improve my code. By the way, I cannot use background combine color and image. It make my background disappear. Could someone explain why that happens and how to fix it? Thank you in advance.

    P
    BillRozy 170

    @BillRozy

    Posted

    good job, pay more attention to design paddings and it would be exactly the same!

    0
  • P

    @bojanognjen

    Submitted

    What are you most proud of, and what would you do differently next time?

    I'm proud of using adequate CSS grid technique. Next time I will try using grid-auto-flow: dense, or something like that to develop more responsive layout.

    What challenges did you encounter, and how did you overcome them?

    I made mistake writing grid-template-columns and -rows, I used auto values and then I remembered fr units. That changed thing a lot and arranged items equally.

    What specific areas of your project would you like help with?

    I would like help how to build more responsive layout for tablets but without using media-queries.

    P
    BillRozy 170

    @BillRozy

    Posted

    Good job! I see some difference in header's avatar and name/title. All the other is very similar!

    0
  • @MajdMohammed

    Submitted

    What are you most proud of, and what would you do differently next time?

    I am proud I could finish one of the hardest challenges I made so far, Next time I will make Layouts using grid faster and without getting confused with grid elements.

    What challenges did you encounter, and how did you overcome them?

    challenges are:

    • Confusion what should be with grid and what should be with flex.
    • what are the proper values to set the grid templates.
    • how should I distribute the the grid and how should I manage it child elements.
    • How should I switch the layouts with grid in mobile screens using the media queries.
    • My main headers disappeared after shrinking the screen.

    I overcome most of these questions thanks to moderators in the Discord community

    What specific areas of your project would you like help with?

    I think I still need to practice a lot for a better understanding of the CSS grid layouts

    P
    BillRozy 170

    @BillRozy

    Posted

    It looks nice, but i think you used wrong breakpoint for desktop, it should start with 1440px, but in your example i see it starts from 1024 or something like this. Also, try to be more accurate with paddings, they differ a lot comparing with design. Good joB!

    1
  • P
    BillRozy 170

    @BillRozy

    Posted

    I would suggest using em/rem instead of px. Also take a look at your media queries, it was defined at least 375px and 1440px as breakdowns

    Marked as helpful

    1