Skip to content
OverviewSolutions
15
Comments
7
Bheki Accion Nkomo
@BhekiAccion

All comments

  • Luciano Lima•1,290
    @LucianoDLimaSubmitted over 2 years ago

    I tried doing it with grid first but I couldn't get it right, so swapped to flexboxes which was a bit easier.

    My code structure is a mess, I'm trying to improve on that.

    Any feedback is welcome

    Four Card Feature - SCSS - Mobile First

    1
    Bheki Accion Nkomo•230
    @BhekiAccionPosted over 2 years ago

    perfect project to master CSS grid, for me it looks like Flexbox may take long and more effort to get it right. But kudos to you, it looks incredible great. On Grid, try mastering the difference between grid-template-column and grid-column. The first states the number of columns you will need while the later is awesome in establishing parameters as to where you want each box to start and end. Once you master CSS grid you will love it and find yourself using it on most layouts. Having said that, it still looks incredibly great.

    1
  • Bheki Accion Nkomo•230
    @BhekiAccionPosted over 2 years ago

    Can anyone help me with the active states for the icons, l could not manage to make them change color to that greenish color needed. Did anyone get that part right?

    0
  • Bheki Accion Nkomo•230
    @BhekiAccionPosted over 2 years ago

    Hey Abdul, thanks for the feedback, l really appreciate it. Yeah normally wrap the content inside the main tag l just forgot on this one, and ohh thanks l always wondered where l can put the attribution because l don't really want them in the main tag. Thank you so much for this feedback. l will grow from this.

    0
  • Bheki Accion Nkomo•230
    @BhekiAccionPosted over 2 years ago

    There is nothing here, you need to take a new screenshot, you probably submitted before the changes had propagated

    Marked as helpful
    0
  • Bheki Accion Nkomo•230
    @BhekiAccionPosted over 2 years ago

    hie, how do you master the shadows part, my boxes dont have a shadow and l kind of struggle with it every time l come across something that needs the shadows. l would appreciate it if you can drop a link to an in-depth lecture or something of that kind

    0
  • Mick•300
    @Mick-2097Submitted over 2 years ago

    Is it just me or is the style-guide.md missing a colour on this one, or is it more set out to get us to match the colour ourselves?

    Price noGrid

    2
    Bheki Accion Nkomo•230
    @BhekiAccionPosted over 2 years ago

    Yeah l also noticed the last box, the Why us box did have a color set for us, l had to kind of adjust the lightness on the hsl to around 45% to 46% so it can maintain the color but have a bit more light.

    1
  • Fetra•40
    @SupafeiSubmitted over 2 years ago

    did it from scratch, thanks for your reviews.

    NFT Preview

    2
    Bheki Accion Nkomo•230
    @BhekiAccionPosted over 2 years ago

    Looks great, well done. Something to note, the original card seems to have a shadow of some sort, or as if the card is nested inside another div, kindly take a closer look at that.

    On accessibility, kindly make sure that all your img tags have an alt text as well. An alt text can be anything really, short description of the image, or you can say Just an image if you want.

    All the best.

    Marked as helpful
    0