@Ross0804Submitted over 3 years ago
Bernard
@BernardanxietyAll comments
- @BernardanxietyPosted over 3 years ago
Hello there. I am a beginner myself but what i see and think is wrong is that You used transform: translateY on bottom cards. I think that this would overflow any content under it,. You may want to seek another solution to this. I didn't know how to add height to the container so i just added margin-top to them. If you go to developer tools and hover over your container, You will see that they spill outside of it.
0 - @jadetrueSubmitted over 3 years ago
I could improve a lot on this - but I would love some constructive feedback overall on my code please.
The overlay is not quite the purple I had hoped for either - any tips would be amazing.
@BernardanxietyPosted over 3 years agoJust to clarify, im a complete beginner just like You trying to learn just like You but what i can already see is not that relevant to the look of it but to semantics of Your html. 10k+, 314 and 12M+ definitely shouldn't be h1s, there should only be 1 h1 per page. On top of that, i didn't do that myself but the "Get insights..." itself shouldn't be a h1 but rather a h2 and those that i mentioned earlier should be like h3s as the challenge is like a section of a whole page i think.
2nd, just an idea, i think You can separate the card into 2 divs, the text and the image and give each 50% of the width of the container so You have more space for the text, see how Your bottom stats are stuck together? If You had more space, You could use flexbox to space them out.
1 - @saravdbergSubmitted over 3 years ago
Hey guys, I would love some feedback over the structure of my code. If anything looks out of place or doesn't make sense, please let me know! Would really appreciate your time and help, thanks!
@BernardanxietyPosted over 3 years agoWow, from a newbie viewpoint, your solution is very clean. I love it!
1
