Skip to content
OverviewSolutions
4
Comments
3
Ben Chi
@BenTheChi

All comments

  • Ben Chi•80
    @BenTheChiPosted about 1 month ago

    I like your use of header as a container. Liked your use of variables. I also found your use of transition for the button interesting. I didn't know about that.

    You left "button active" on for Frontend Mentor. Turning that off should fix the bug. I think "Front-end developer and avid reader" is supposed to be a lighter font. Other than that everything looks good.

    Marked as helpful
    0
  • Ben Chi•80
    @BenTheChiPosted about 1 month ago

    I don't think the yellow part was supposed to be fixed. I thought it was supposed to fill the background. There's some issues with spacing issues (Greg Hooper and logo), font color, padding, and alignment I see as well. The active hover features over "HTML & CSS foundations" is missing too. I think you should use flex on your first and second containers as well to help with alignment. Good attempt though. I encourage you to try again on this one as it's only going to get harder with each challenge.

    Marked as helpful
    0
  • Sayed Ali•90
    @sydalwedaieSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    I guess I had my first proper CI/CD setup! Here's my process at the moment:

    • Initialize local repo.
    • Work on the project, commit changes along the way.
    • When finished, run gh repo create (a GitHub CLI tool). This would create a remote repo, connect it to the local repo and push the commits to the remote repo.
    • Run netlify init (a Netlify CLI tool) to create a new Netlify website from the newly created remote repo.

    With this setup, I never leave the terminal! Even better, any changes I make to the local repo can update the live website using a simple git push command.

    What challenges did you encounter, and how did you overcome them?

    Vertical centering has become much easier with Flexbox. However, it gets a bit tricky when flex direction is vertical. I gave the body a hight of 100vh, so I could use the Flexbox vertical centering technique. Otherwise, justify-content won't work when in vertical mode.

    QR Code Component

    1
    Ben Chi•80
    @BenTheChiPosted about 2 months ago

    Looks great. Way better organized then mine. So think it's all good. I did more inline styles and an embedded style, but yours is a more proper way.

    0