Feel free to leave any feedback on my solution. It is greatly appreciated.
Thank you in advance
Feel free to leave any feedback on my solution. It is greatly appreciated.
Thank you in advance
Nice attempt at this challenge. Some issues-
Hope this helps.
Hi! I struggled a lot with the CSS of this project. A couple times I felt like giving up. The custom button was definitely a challenge in terms of styling and functionality. Also, initially github couldn't compile the site, so that's why the different commits. I am not sure what went wrong with that... Anyway, I'm proud that I have finished this project.
Any suggestions for improvement are appreciated!
Nice job completing this challenge. There are some places where you could improve -
You can have a look at my attempt to see what I meant.
The challenge was exciting as it was a great example of creating card components with CSS. Also, concepts like box shadows, CSS backgrounds, and positioning are learned while designing/building this challenge. Although it was a simple task, it had its fair share of challenges that I would love for you to help me solve.
The main challenge I encountered was, "How do I center the card in the middle of the page without using CSS Flexbox?" Although I added margin-top to the card to push it down, this method may not be effective in achieving the desired result. As a result, I pose this question.
The second issue I encountered was, "How do I position the footnote perfectly at the bottom of the page?" Centering the footnote proved challenging as I tried playing with the 'position' property, but I could not center the footnote. In the mobile screen layout, it even overflows below the screen. Therefore my second question is.
margin: 2.5rem auto;
. This is shorthand. 2.5rem is the margin-top
and margin-bottom
.position: absolute;
left:50%;
transform: translateX(-50%);
min-width
.Search on stackOverflow and MDN for these queries. They have explanations in great detail.
Great job completing this challenge. JS looks good to me. Some issues with the css-
Hope this helps.
I have been difficult to set the name for components and pass state to components. Looking forward to your advice so I can improve my skills. Have a good day
Great job completing the challenge. Some issues -
border-radius
is missing at some places.background: no-repeat
and background-size: cover
to avoid repetition of background-image.Hi, I am learning Sass. I would like to have feedback on best practices and on design and code. This will help me learn sass and react.
Nice job completing this challenge. Some issues:
Background-color
of body is missing.display: flex; align-items: center;
.Hardest challenge I faced so far. This really pushed me to the edge. Spent like 3days figuring out to achieve all the active states. Learnt a ton of new things like global state management, modal-overlays, effective component structuring. Would appreciate feedback on any missing JavaScript feature or site responsiveness. Feel free to criticize.
Hello fellow front enders!
This project was a bit tedious at the end but the beginning was quite fun. I fine tuned the project with Pixel Perfect Pro (free Firefox extension to overlay the preview image over your site for to-the-pixel fine tuning)
I have a detailed, and hopefully not verbose, README you may want to read. Otherwise any helpful advice, tips and tricks would be much appreciated!
Thanks a ton! Gareth
That's actually a very good extension. Thank you for sharing.
I just found a slight error which you may want to rectify. It's not significant but still caught my eye.In the mobile layout the border-radius is not being applied to the top-left and top-right corners of your main card. You can enforce that using overflow: hidden
. Hope this helps.
Hello nice attempt at this challenge. Some points where there can be improvement -
This is my third challenge and by far the most difficult for me, specially because it involves deeper javascript logic. The CSS part was ok, but not easy like the other challenges I did, the most difficult part of this challenge was definitely the JS part. I tried to use Classes, but it didn't go well, so I just used a bunch of function, and it worked!
I would like to know if there's a quicker/more effective way of getting the same result, maybe using class? I don't know, my solution looked like I did too much of unnecessary work at some points, but I don't know where.
Anyway, I had a lot of fun doing this, even tho' I took like 2 days to finish it :^)
Definitely agree that the Javascript was the most difficult part. Some points -
<input type='number' />
, maybe use <input type='text' />
or simply remove the spinner arrows to improve the UI.@jrmydix I like the JS here. The only feature which might cause some trouble is the responsiveness. For the tip percentage buttons
instead of using flexbox you can use grid which will allow more control over the width and not collapse the buttons into a single column below 374px. Just my humble opinion.
Would like some valuable feedback on the responsive-ness of the site and where I can improve.
Spent a lot of time on the javascript part and added some states for the inputs. Any inputs on how I can improve the javascript will be highly appreciated.
Also facing a lot of trouble in styling in React. Any resources for learning how to manage that?
I don't know how the white space is appearing to the right and the bottom. It looks alright on live site.