Skip to content
OverviewSolutions
2
Comments
2
Bastien Winant
@BastienWinant

All comments

  • P
    Bastien Winant•20
    @BastienWinantPosted about 1 month ago

    Great job reproducing the style and layout from the design. The only missing part here would be the black accent, which you can achieve using box-shadow in CSS.

    Creative use of React for this project. For reproducibility purposes, I would avoid using an h1 inside the Card component, as there should be only per page.

    0
  • Jenelle Holloway•30
    @hollowayjenelleSubmitted about 2 months ago
    What are you most proud of, and what would you do differently next time?

    I'm proud of being able to replicate the design.

    What challenges did you encounter, and how did you overcome them?

    No challenges

    What specific areas of your project would you like help with?

    N/A

    QR Card Component using React

    #react
    1
    P
    Bastien Winant•20
    @BastienWinantPosted about 1 month ago

    I find the use of React and TS very interesting for this project. The design has been recreated with great detail.

    For accessibility purposes, I would be good to add an H1 element (even if hidden). If using React anyway, you might want to pass the qr code image as a prop to make the component reusable.

    The above are just suggestions as I did not find any major issues with your solution. Good job!

    0