@Zana994
Submitted
Any feedback?
@BasileRaiwet
@Zana994
Submitted
Any feedback?
@BasileRaiwet
Posted
Hi Zana ! Great work ! here are some ideas to improve your solution :
the gallery section is a bit tight on my 13 inch device (boxes are touching each other). Maybe you can put some margin between each boxes (or use gap but gap is not well supported actually). If you want to try, you can use css grid to build this section. I think it will be easier.
you define your section width with width: 80%
on your .frame
class. The problem is that your container (and potentially his children) will extend too much on large screens.
In most cases, it's better to set the width with a strict value (like on this website).
In this way, the content will be centered and your website will be readable on any screen size
Hello everybody, i expect you have a nice day.
Here go another challenge, all feedback well be welcome.
@BasileRaiwet
Posted
Hi Samyr !
Great work ! I just see some points you can improve :
@domiattaway
Submitted
I don't understand. When I do the live view of my work from Vs code it is working but when I upload it to vercel it is distorted. Looking ofr feedback. Thanks
@BasileRaiwet
Posted
Hello Dominique !
As Samyr said, check if your work is up to date on github and then re-deploy to vercel.
I also have some recommendations for you :
@bobaram
Submitted
From the very start i struggled with this project . I need feedback on how i should have structured my HTML and which tags i should have used. I am still learning and would really appreciate any sort of feedback no matter how critical it is .
@BasileRaiwet
Posted
You can easily improve this solution by adding some padding / margin in order to fit with the design. Also, look at the design file to find correct font-size for your headings / content. don't forget details like border-radius and box-shadow.