All comments

• 

  Ritam Mishra•30

  @ritam-mishraSubmitted over 2 years ago

  This was a tough challenge and I tried to do it as simple as possible.

  Can suggest whether it is a good practice to use <span></span> tags inside <p></p> tags and then changing the style of the spans separately? (you can see I used span for 26, London, followers, likes and photos and then changed its color separately) Can it be done or is there's an alternating way, please suggest.

  I would request everybody to go through my simple code and please correct any error if you find. And you are free to give any feedbacks, which I will accept wholeheartedly.

  

  Profile Card Component Solution

  3

  20
  

  Azan•140

  @Azi-01Posted over 2 years ago

  Hi, Good job on the solution! It looks nice and pretty close to the design. I checked out the site and your code, and noticed some things, so I would like to give a few suggestions. First, I noticed that the profile image and the white border around it has a gap and the background is leaking through it. Try replacing border: 5px solid white; with outline: 5px solid white; in .profile-pic img rule set. Second, try wrapping all the content in <main> </main> tags and use <div> to group different things together.

  I hope this helps! and again well done on the solution :)

  Marked as helpful

  0