I appreciate so much if you take a bit of your time and give me a feedback. Thanks.
Axurynn
@AxurynnAll comments
- @Facu3071Submitted over 2 years ago@AxurynnPosted over 2 years ago
Good job @Facu3071 !
To fix issues, you could add a
main
tag to your HTML file as well ash1
title.Overall, you did well! Congrats and happy coding 😄
Marked as helpful0 - @11arshaanSubmitted over 2 years ago
Hello.
I was thinking about using bootstrap for this, but decided to try coding the entire thing. The responsiveness is not how I planned for it to be; I think the bootstrap columns would solve the issue. Or maybe if I used a media query, but what would the settings for the elements be in each query?
Also, what is the recommended method for creating the hover state for the image?
Thank you!
@AxurynnPosted over 2 years agoGood job @11arshaan !
For the responsiveness, you could use
@media
queries but you could also use amin-width
property. In this case, you could "block" the card width (at 300 px for example) so as it can't go lower. This could fix your responsiveness for the mobile version.Overall, you did it well ! Congrats and happy coding 😄
Marked as helpful1 - @shravankumartalabhaktulaSubmitted over 2 years ago
Hi there,
I'd like to have feedback from you.
- My design is not mobile friendly for now, I tried my level best to implement the responsiveness for few screen sizes. I'd like to know what all generic screen sizes available and how to target them while developing the mobile first design strategy?
- Am I following the best practices while writing the scss files?
- Can you please suggest me where I need to improve and some tips and tricks on how to plan before starting to code.
Thank you so much for your time.
@AxurynnPosted over 2 years agoGood job @shravankumartalabhaktula!
To fix accessibility issues, you could add a
main
tag to your HTML file as well ash1
title. About the responsiveness, you could addmax-width
properties or use@media
queries. For example, themin-width
you could use in your media queries are 480px for mobile, 767px for tablet and 1280px for desktop.Overall, you did well! Congratulations! 😊
0 - @abhay0480-engSubmitted over 2 years ago@AxurynnPosted over 2 years ago
Good job!
To fix accessibility issues, you could add a
main
tag to your HTML file. About the responsiveness, you could addmax-width
properties or usemedia
queries.Overall, you did well! Congratulations! 😊
Marked as helpful0