Skip to content
OverviewSolutions
1
Comments
2
Avinash
@Avinashkumar906

All comments

  • Olaitan•230
    @Olaitan01Submitted over 1 year ago

    I built 🛠️ this project with Html, Sass, and Javascript and I learned how to handle error messages and how to make a custom one. I tried make it accessible as possible but I will appreciate any tips on how to better the accessibility. Please Kindly help me review it and give me your feedback. Thank you.🙏

    Newsletter-Signup-Page built with HTML, CSS and JAVASCRIPT 🛠️🛠️

    1
    Avinash•40
    @Avinashkumar906Posted over 1 year ago

    This looks great but I have some points where you can do improvement.

    1. Code is not responsive in nature.
    2. In error state "valid email required" error message is not appearing.
    3. On success state, subscribe form is visible behind the popup message.
    0
  • Avinash•40
    @Avinashkumar906Posted over 1 year ago

    Hi Lin, Solution is good but i thing there should be one improvement. On desktop it looks fine but when switching to mobile view it is breaking so i suggest to put some CSS below 567px width instead of 375px as lots of mobile screen has more than 400px width. :)

    Marked as helpful
    0