Skip to content
OverviewSolutions
5
Comments
5
Autumn
@AutumnCod

All comments

  • Autumn•110
    @AutumnCodPosted almost 3 years ago

    Hi!

    Well done to complete the challenge! There is a few suggestions.

    1. Accesbility: For the main content use the main tag. It will tell the people that everything inside the tag is the focus content of the page. And I would suggest to use the article-tag instead of section. -->https://webdesign.tutsplus.com/articles/the-truth-about-multiple-h1-tags-in-the-html5-era--webdesign-16824
    2. I am aware it is small project but I would always put my css in a seperate file and link them.
    Marked as helpful
    1
  • Autumn•110
    @AutumnCodPosted almost 3 years ago

    It would be great to have a link to the repo, but beside that I like your animation very much. Great work!

    Marked as helpful
    0
  • Autumn•110
    @AutumnCodPosted almost 3 years ago

    Hi! For the next challenge I would suggest to look up html5 Element. It will help you with your accessibility issue instead of using always divs. Aside from that I noticed the margins are a bit off here. Like you I am using the free challenge only and it helps me to use Figma to get the right padding and margin - or at least being closer to original. Everytime I open a new Design file and use the rectacle tool to measure it out.

    0
  • Autumn•110
    @AutumnCodPosted almost 3 years ago

    I would suggest that you use: background-blend-mode: multiply instead of screen(on the image)

    Marked as helpful
    0
  • Autumn•110
    @AutumnCodPosted about 3 years ago

    In the future dont delete the meta data. They have different purpose like responsibility. E.g. : <meta charset="UTF-8" /> <meta name="viewport" content="width=device-width, initial-scale=1.0" />

    0