Skip to content
OverviewSolutions
6
Comments
3
Arindam Sankar Das
@ArindamSankarDas

All comments

  • Arindam Sankar Das•90
    @ArindamSankarDasPosted over 2 years ago

    I viewed a bit of your code on Github. First, your folder structure is a complete mess and you should start by placing your style, and script files in their specific folders. Now, coming to your JS code I want to point out many things but I'll just point out the major ones. In your code, you are retrieving data from arrays manually, meaning you are defining the array variable and passing the index value of that array. Example: array[0] = some code. This is a bad practice and it stood out more than anything in your script. I have completed this project so you can go and check it out or if want help to refactor your code, I will help you. Give me a reply or send me an email at [email protected]

    0
  • Kristiana12•425
    @Kristiana12Submitted about 3 years ago

    I couldn't get the background how it should be,

    could somebody please give me a hint of how I could have done it better?

    Thank you!

    Built with Flexbox

    2
    Arindam Sankar Das•90
    @ArindamSankarDasPosted about 3 years ago

    So far the project is very good but you could have minimised the HTML elements by using pseudo-selectors.

    But, except all is pretty good

    1
  • Arindam Sankar Das•90
    @ArindamSankarDasPosted over 3 years ago

    Hey buddy, I looked up at your source code on Github and the first thing I noticed was that your project structure is a complete mess. Try to structure it properly next time so that other developers do not have to spend much time looking for the specific file.

    Now, from the code basis :

    You could've have used separate files for the variables, colors and repeated block of codes to make your root SCSS file, i.e. the styles.scss file a little shorter.

    Secondly, if you're new to frontend then it's completely fine to use the current html pattern but try to use less html tags and utilize pseudo elements that CSS and CSS3 provides us with.

    Other than that keep trying, keep practicing and you'll get better at it.

    1