Skip to content
OverviewSolutions
6
Comments
4
Anubhav Ray
@Anubhav-Ray

All comments

  • Shaheed Wajee•220
    @wajeeNPCSubmitted over 1 year ago

    First time doing java-script, This challange took multiple hours to complete it and if theres any issues or complement please let me know,Thank you.

    Interactive-rating-component

    1
    Anubhav Ray•140
    @Anubhav-RayPosted over 1 year ago

    Hi @wajeeNPC

    Congrats on completing your first JavaScript project.

    I have some suggestions you might consider to improve your code.

    • To make your webpage accessible you should use atleast one main tag to cover your entire html and use forward slash to specify path for image and try to use semantic html.

    • Use alt tag for images that have some special meaning so that it might be helpful for screen readers.

    • Your rating is being submitted even if user has not selected any rating.Try to disable the submit button until user has selected the option.Its giving selected 0 out of 5.

    • Multiple ratings are being selected (or their color state is being changed) if one tries to click on every rating so try to fix it.

    • In submit button you have used spaces in html itself to make spacing between the letters of word submit.Try to use CSS letter-spacing property.

    • You should also write a detailed Readme so that others can gain additional insight on your project.

      Above all, The project is Well Done.I hope these tips will help you.
    Marked as helpful
    0
  • Justine Santos•10
    @hyxenonSubmitted almost 2 years ago
    1. Changing the mobile image product to desktop image.
    2. Setting the source image
    3. How do I change the mobile image product to Desktop image product?

    Media Query, Flex, Grid

    1
    Anubhav Ray•140
    @Anubhav-RayPosted almost 2 years ago

    Hi @hyxenon. Congrats on Completing the Challenge.

    You can use picture tag for setting two different images.

    To make your webpage accessible you should use atleast one main tag to cover your entire html after body tag and should use semantic html

    Marked as helpful
    0
  • Anubhav Ray•140
    @Anubhav-RayPosted about 2 years ago

    Hey @iSoyecodes for Responsive background pattern use Media Query.

    You can set default background-image of body tag as the image given for mobile background-imagein design if you make mobile-first design and use media query for setting body tag background-image as the desktop image for desktop design.

    Marked as helpful
    0
  • Anubhav Ray•140
    @Anubhav-RayPosted about 2 years ago

    Hi @JuanRodriguezz Good Job Completing this Challenge.

    I have some suggestion you might consider to improve your code:

    1. You can make $149 bigger by using font-size property instead of using h5.

    2. You can add Cart Icon before the text Add to Cart by using Bootstrap Icons

    3. You should also try to make both prices horizontally aligned as given in design.

    Above all, The project is Well Done.I hope these tips will help you.

    Marked as helpful
    0