W I L B U R• 80
@Citizen2405
Submitted
Antonio Riccelli
@Antonio-Riccelli
All comments
- Antonio Riccelli• 80
@Antonio-Riccelli
Posted
Hey Wilbur, nice job on this solution!
Good idea about using SASS/SCSS, I did the same thing.
A couple things to consider:
-
The challenge design images show the bullet/number of the unordered/ordered lists also have to be styled in a certain colour. This is actually interesting, as it will get you to think how you can do that while keeping the text of a different colour.
-
It's always a good idea to update the README. Although for a small project like this it might not make a massive difference, it will get you into the habit of doing so, which will come in handy later.
Hope this helps!
0 -
- Sudhanshu Thapa• 120
@Sudhanshu943
Submitted
Antonio Riccelli• 80@Antonio-Riccelli
Posted
Hey Sudhanshu, good work 💪
Some things you could consider:
- Although
<span>elements can be used to mark microdata or other metadata, you could also consider using block-level tags like<p>or<div>or even heading tags. This could make them more semantically relevant. Just an idea. - You could consider splitting the CSS to its separate stylesheet file, but I understand that in such a small challenge it won't make a huge difference.
Hope this helps! Good work and best of luck with the next challenge.
Marked as helpful
0 - Although
- Soniawan• 100
@soniawan
Submitted
Antonio Riccelli• 80@Antonio-Riccelli
Posted
Well done on the solution and nice use of the transition for the focus state.
Good idea to add media queries for responsiveness and a few comments to help readability.
There isn't much to add. You might want to consider storing the colours in variables that can be reutilised across the code. Although this isn't necessary in small project or challenges such as this one, it's a habit that can come in handy in the future.
Marked as helpful
0 - PAdam Whitehouse• 110
@adamwhitehouse95
Submitted
What are you most proud of, and what would you do differently next time?
I'm happy with my ability to reseacrch solutions and overcome a problem when i hit a roadblock in this project. Next time i would do more commits as i had to start over once when i was half way through, although i appreciate the extra practice.
What challenges did you encounter, and how did you overcome them?
I didnt know how to make a child elements property change when i hover over the parent element but after a quick google it all made sense.
What specific areas of your project would you like help with?
I'm not confident with my code and even though everything looks good im not sure its good quality so some feedback would be nice.
Antonio Riccelli• 80@Antonio-Riccelli
Posted
Well done on your solution and good on using Flex.
I don't have much feedback except possibly you could store the colours in variables to make them easier to reuse. However, in such a small project it won't impact things negatively.
0 - Mason Horne• 10
@MasonScottHorne
Submitted
What are you most proud of, and what would you do differently next time?
I am most proud of my work, if I had to do this project over again I would try to not use ChatGPT as much.
What challenges did you encounter, and how did you overcome them?
I came into some challenges with the styling.
What specific areas of your project would you like help with?
None
Antonio Riccelli• 80@Antonio-Riccelli
Posted
This looks good! I completely empathise with the struggles regarding styling. It never turns out to be as simple as you initially thought it would.
The code looks good as well! Some suggestions:
HTML
- Consider using semantic tags (e.g.,
<main>instead of<div>s), this is very important for accessibility, but it will also make your code more readable and debuggable. - Consider adding an actual value for the
altproperty of your<img>tag.
CSS
- This is just about experimenting a different approach. You could consider assigning colors to variables. Check this for a better explanation: MDN In small challenges, it won't make much of a difference, but it will come in handy in larger projects.
0 - Consider using semantic tags (e.g.,
