@JoseAlfonzo92Submitted about 1 year ago
Feedback welcome.
Anosh Sohail
@AnoshSohailAll comments
- @AnoshSohailPosted about 1 year ago
Hey, The image isn't showing up. Try this code
<img src="./images/image-qr-code.png" alt="Front-end development qr">Marked as helpful0 - @MedHam94Submitted about 1 year ago
hello, for me was too good, and the only issue I found was the <p> margin and padding, Even if I set the margin and padding to 0 in the first lines, the <p> still had them, Wichwas confusing for me,
@AnoshSohailPosted about 1 year agoHey, Good job on finishing this project.
- The margin on the <p> element is coming from the
.paragraphclass. You have set themargin-bottom:25px. - There is another cancel order present at the top left corner of the screen.
0 - The margin on the <p> element is coming from the
- @studimeytSubmitted about 1 year ago
I am still quite unsure in display and positioning part and how they work exactly but will get around it eventually
@AnoshSohailPosted about 1 year agoHey, Good job on finishing this project. There is one thing which will improve your HTML code. Use semantic HTML For example instead of
<div class= qrcode-box>use<main class="qrcode-box">Same for<div class = "attribution">use<footer class=attribution>Marked as helpful1 - @allancorp23Submitted over 1 year ago
So the question was good and easy but thanks for continuosly providing us with great questions that enhance our knowledge and skills.
@AnoshSohailPosted over 1 year agoHey,
- Using h1 tag to point the main heading of the page is important to improve accessibility.
so instead of
<h4> Join our community </4>. use h1 tag<h1> Join our community </h1>
0 - Using h1 tag to point the main heading of the page is important to improve accessibility.
so instead of
- @NoyanSeckinSubmitted about 3 years ago@AnoshSohailPosted about 3 years ago
Hey, You have uploaded the wrong live site URL. Please update the URL and generate the screenshot again. 😊
0 - @ShmuelAmirSubmitted about 3 years ago@AnoshSohailPosted about 3 years ago
Hey, You have uploaded the wrong live site URL. Please update the URL and generate the screenshot again. :)
0 - @Iamweird2Submitted over 3 years ago
hi, please review my code
@AnoshSohailPosted over 3 years agoHi, Maybe that's because of font-family.
Try this
body{ font-family: 'Lexend Deca', sans-serif; }
Marked as helpful0 - @faizalnurSubmitted over 3 years ago
hi.. beginner front end here, i tried to post this challenge any feedback would be appreciated
