AndresOreVel

Latest comments

• 

  P

  Dave Lilleystone•170

  @davelilleystoneSubmitted 3 months ago

  

  Testimonials Grid Section

  2

  50
  

  AndresOreVel•160

  @AndresOreVelPosted 3 months ago

  Excellent job

  0
• 

  WinterToFall•20

  @David-DermawanSubmitted 3 months ago

  

  Four Card Feature Section using grid and flex

  1

  20
  

  AndresOreVel•160

  @AndresOreVelPosted 3 months ago

  I would highlight several things: For the “line-height” it is better not to use units, since in this way the line-height is relative to the font-size. Relative units like rem allow for more flexible and scalable design. For example, if a visually impaired user increases the font size in their browser, the margins and padding defined in rem will also increase proportionally, improving readability and navigation. With px, this would not happen.

  You could create global variables for colors in your css. :root{ --Very-Light-Gray: hsl(0, 0%, 98%); } And then you would use it as many times as you want, without having to rewrite everything again.

  body{ background-color: var(--Very-Light-Gray); }

  0
• 

  Arshal Rejith S•140

  @iamarshalrejithSubmitted 3 months ago

  

  Product preview card

  1

  30
  

  AndresOreVel•160

  @AndresOreVelPosted 3 months ago

  Generally speaking, it's pretty good. But I would make some changes. It's good practice to apply a general reset like this at the top of your css document: *{ margin: 0; padding: 0; box-sizing: border-box; } And not only for the body.

  For the color and font-family theme you could use variables. It would look something like this: p{ font-family: var(--Fraunces-font); background-color: var(--Dark-cyan); } And at the beginning of your css you would put this: :root{ --Dark-cyan: hsl(158, 36%, 37%); --Fraunces-font: "Fraunces", serif; } This way you would save many lines of code.

  Marked as helpful

  0
• 

  P

  MartynaGit•170

  @MartynaGitSubmitted 4 months ago

  What specific areas of your project would you like help with?

  1. I have a big problem with tables.
  2. problem with setting the container to adjust to the size of the browser window
  3. I don't know if the lists are constructed well.

  

  I used media queries

  1

  30
  

  AndresOreVel•160

  @AndresOreVelPosted 3 months ago

  It is good practice to wrap the main content in a main. For accessibility, so that whoever is going to touch the code knows how to quickly identify it. In the image, always add content to the "alt". Whatever its content, it is a description that provides relevant information about the image to people who need it. Try to use only one h1 label throughout your code and only for the page header. You could use global variables when using colors for example, just add :root{ --Stone-100: hsl(30, 54%, 90%); }

  body{ background-color: var(--Stone-100); } This way you will save many lines of code.

  0
• 

  P

  JeremDevX•220

  @JeremDevXSubmitted 3 months ago

  

  Social Links Profile - Vanilla HTML / CSS

  1

  40
  

  AndresOreVel•160

  @AndresOreVelPosted 3 months ago

  It's pretty good, but I would change the font-size. Use rem instead of px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser

  Marked as helpful

  0
• 

  Rounak Kumar Singh•110

  @rounakkumarsinghSubmitted 3 months ago

  

  Responsive Blog Preview Card

  1

  10
  

  AndresOreVel•160

  @AndresOreVelPosted 3 months ago

  Overall it's pretty good but I would do some changes if I could access to the code.

  • On the body I would add a padding of 16px so that on smaller screens the edge does not stick to the edge of the screen
  • A card max-width of 330px for example
  • A border radius of 1rem on the image-card desides a margin-bottom of 1rem
  • As for the paragraph, I would also add a margin bottom of 1rem

  0