Amit-R328
@Amit-R328All comments
- @Michalol94Submitted 3 months ago
- @steffieMDSubmitted 3 months agoWhat are you most proud of, and what would you do differently next time?
my improved css skill
What challenges did you encounter, and how did you overcome them?developing without the figma file
- @AmirxonEngineerSubmitted 3 months ago@Amit-R328Posted 3 months ago
Great job!
One suggestion would be to replace the outer <div class="container"> with <section class="container"> to provide semantic meaning, designating the container as a distinct section of your webpage.
maybe also use variables for the colors?
:root { --primary-yellow: #f4d04e; --black: #111; --gray-dark: #6b6b6b; --white: #ffffff; --blue: hsl(228, 45%, 44%); }
0 - @Yago14Submitted 3 months ago@Amit-R328Posted 3 months ago
Very good! The only thing missing is the hover state CSS for the navbar links. You can add this with a simple animation in CSS:
&::after { content: ""; position: relative; display: inline-block; width: 100%; height: 2px; background-color: $White; transform: scale(0); transition: transform 0.3s ease-in-out; transform-origin: right; top: -12px; }
Marked as helpful1 - @BrkCoderSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I wrote clean code and took into consideration every css line which I wrote and also take into account which html entities to use in the right way.
What challenges did you encounter, and how did you overcome them?responsiveness of website using flexbox
What specific areas of your project would you like help with?css
@Amit-R328Posted 4 months agoPerfect!
but I'm not sure what is the use in: *, *:before, *:after { font-family: inherit; box-sizing: inherit; }
0 - @kirilzabSubmitted 6 months agoWhat are you most proud of, and what would you do differently next time?
i'm proud of this work, although it's not very difficult, it's still
What challenges did you encounter, and how did you overcome them?more difficult was to place the view image in the correct position
What specific areas of your project would you like help with?@Amit-R328Posted 5 months ago-Good use of CSS variables for maintaining a consistent color scheme across the project.
-The * selector reset for margin, padding, and box-sizing is a good practice for consistency.
-Media queries are well-used to adjust the card width for mobile views.
Very good
Maybe you can simplify the hover effect by using a single class (.overlay)
0 - @CheosphereSubmitted 10 months ago
...made with a lot of love 🤘🏻🙂
@Amit-R328Posted 7 months agoAmazing work! actually pixel perfect. Thanks a lot for the like, it's an honor to get it from someone as talented as you
1