Skip to content
OverviewSolutions
20
Comments
36
Aman Patil
@Amanpatil-Dev

All comments

  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello Hoang👋

    Your solution looks good and has all JS functionality as required👍

    -The issue that I found was in mobile width that is 425px your image of class header__imgContainer overflows and the hr line also. I have made a pull request on your github fixing this issue please do check it and merge if it looks appropriate to you.

    That's All Happy Coding👍

    0
  • Writam Biswas•105
    @bwritamSubmitted over 3 years ago

    my first attempt to js. please let me know how can i do better on works.

    html , css, js

    3
    Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Nice job Writam 👍 Looks good and responds well too

    Marked as helpful
    0
  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello Indra👋

    Your solution looks good and respond well nice job👍

    -The issue that I found was not an issue to be honest, but the reset button should be disabled till user inputs the number and then after clicking on reset button the reset button should be disabled again.

    That's All Happy Coding👍

    0
  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello Sebastian👋

    Your solution looks good and. Responds well 😀

    nice job👍

    -The issue that I found was in all the inputs field I as a user can type words, and negative values it should not be valid

    -Missing was Active States of input fileds and validation of No of people input field

    That's All Happy Coding👍

    Marked as helpful
    1
  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello Kiran👋, Nice job on this Challenge I really Like the Animation on Hover 👏

    Your solution responds well and Everything looks good to me 👍

    Just one thing i would like to correct although its not an issue at screen width 1600px your .column .card width increases what my recommendation is when we go above 1500px decrease the width of .column width of 22% would work I think.

    Thats all.

    Hope this helps✌️

    Happy coding😃

    0
  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello Mayura👋, Your solution responds well and Everything looks good to me 👍

    One advice I have is when making any design first what I do personally is scale down the browser width to 425px and design according to mobile first and then scale up for like 768px then 992px then 1200px what this do is make the design more mobile friendly scaling up would be easy because u just have to write media queries for scaling up

    For Example if you see your each card gets Skinner when you go to screen-width 801px till 1022px

    so your can write

    @media (min-width:801px){ .flex-container{ width:100% } }

    -Explanation:-we say that when you will go to Screen-width of 801px and greater than 801px apply width of 100% to class .flex-container

    then after scaling up to screen width of 1022px you can say

    @media (min-width:1022px){ .flex-container{ width:72% } }

    -Explanation:-Here we say that when you will go to Screen-width of 1022px and greater than 1022px apply width of 72% to class .flex-container

    Hope this helps✌️

    Happy coding😃

    0
  • Richard Cyrus•465
    @richardcyrusSubmitted over 3 years ago

    Feedback welcome. The only thing I haven't yet figured out is the best way to set the Portfolio entry as active when on a project detail page. I think I've met all of the other design requirements.

    Minimalist Portfolio - React, Next.js, SASS

    2
    Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello Richard👋 So Awesome!! Its look cool on desktop nice job👍

    -The issue that I found was when you go to screen width 767px to 753px The navbar gets Un-Styled

    -The hamburger for mobile nav-bar get Displayed at width 752px No Problem, But the placement of the navbar is little off when open navbar under screen-width 700px

    That's All Happy Coding👍

    Marked as helpful
    0
  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello SHIBU, Your solution responds well and Everything looks good to me 👍

    Maybe Just Selecting a good font-family would make it look more good

    Happy coding😃

    Marked as helpful
    0
  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Looks good in desktop by the way 👍

    Little bit of un-alignment in mobile width .

    One advice I have is when making any design first what I do personally is scale down the browser width to 425px and design according to mobile first and then scale up for like 768px then 992px then 1200px what this do is make the design more mobile friendly scaling up would be easy because u just have to write media queries for scaling up

    Hope this helps👍

    Happy coding 👌

    Marked as helpful
    0
  • Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Looks alright To me Good Job 👍

    Marked as helpful
    0
  • Daniel Dudu•380
    @danielduduSubmitted over 3 years ago

    Nice challenge where I tried to write clean markup and style as close as possible to design.

    Of course, it is not perfect, but it feels good to give it a try.

    Any comments & observations are highly appreciated :)

    Thank you all and happy coding!

    HTML5 & CSS3

    3
    Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Great job Daniel 👌👌

    Everything looks good and respond well 👍👍

    0
  • Dmytro•305
    @DmytroTarasiukSubmitted over 3 years ago

    I was focused on a practise so I didn't pay attention to the typography. Also, I changed a little bit a footer. The rest are exactly the same.

    HTML5, CSS3, JS

    1
    Aman Patil•885
    @Amanpatil-DevPosted over 3 years ago

    Hello Dmytro🖐️, You did an amazing job 👌. your solution looks good and responds Good.

    The only issue I found was wrong path to the class images

    Given :- /images/desktop/image-gallery-milkbottles.jpg

    Should be:- ./images/desktop/image-gallery-milkbottles.jpg

    just add a dot for absolute path for every images inside class image-container

    That's All👍

    Hope this helps🙂

    Marked as helpful
    1