Skip to content
OverviewSolutions
20
Comments
26
P
AjeaS
@AjeaSmith

All comments

  • AjeaS•715
    @AjeaSmithPosted over 3 years ago

    Really nice job on this! :D

    0
  • AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Thanks! :) and good catch I’ll check that out. Yea it took me quite some time to get the background image to work.

    0
  • AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Hey Aayushi, great work on this! break points scale perfectly. Keep up the good work.

    0
  • AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Hey Waseem, wow this great on all sizes good work!

    1
  • AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Hey Sarvagya, your solution looks great! nice work. Has doing the font awesome that way always gave you trouble? I usually get the css from CDN and import it as a stylesheet with link tag. using https://cdnjs.cloudflare.com/ajax/libs/font-awesome/5.13.0/css/all.min.css not sure if that helps, let me know. :)

    0
  • AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Hi Migo, great work on this! If it's a background image you could try setting the background-position property, maybe something like background-position: top right. Let me know if that helps.

    1
  • Shubham Sharma•855
    @shubhamthedevSubmitted over 4 years ago

    Hi, this is my third project over here and i want some feedback on this project. I am open to any suggestions you might have and any criticism about my design or the style of coding.

    Huddle Landing Page with Sass

    2
    AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Hi Shubham!, Great work on this project! just a few suggestions

    • I noticed the design breaks a bit when it gets to 914px I would suggest the media query break point to be before then.

    • I see within your code you use the header tag to wrap your whole content. Probably just a preference thing, but I usually use the header tags for menu-like content like nav bars, and logos. Then I would use either the main tag or a section tag for regular content.

    • The last thing I noticed is that there is a script tag at the top, inside the head tag. It's best practice to place any script tags at the bottom of the page, namely right above the ending </body> tag. That way when the browser runs, it loads the content first then any JS scripts.

    Other than that, again great job! :) keep up the good work.

    P.S. Hope this makes sense

    2
  • AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Hi Jim, Great job on this! the mobile and desktop view looks exactly like the design. I'm curious what was it you weren't able to accomplish in this challenge?

    1
  • AjeaS•715
    @AjeaSmithPosted over 4 years ago

    Awesome job! like @emmy-html said, your solution is very close to the design. So again, awesome job on that. I noticed that you have a few accessibility issues, which I see are an easy fix. It's basically saying for best practices when working with links <a></a> tags, if the link is not actually going anywhere like to navigate to a different page it can look like this <a>my link</a>. Or, if you are navigating to a different page then, using the href attribute like you did before is the way to go. Nonetheless, great work!

    P.S. hope that made sense :)

    1
  • AjeaS•715
    @AjeaSmithPosted about 5 years ago

    Hey Glory, nice work on this challenge! I did noticed on min-width 501px the bottom boxes overlap. I’m curious if you tried using the mobile first approach. I believe it would be a much easier for you, starting off on a smaller screen and working your way to bigger screen. So for instance,

    1. On smaller screen you could add a flex-direction: column on the .sub so that they’re stacked on top of each other.
    2. Then, maybe you could add a min-width: 774px media query and change the direction of .sub by using flex-direction: row

    I hope that makes sense, nonetheless you did a great job. keep up the good work! and let me know if you need help with anything.

    1
  • AjeaS•715
    @AjeaSmithPosted about 5 years ago

    Good job on this challenge Savaaa22, it looks great on mobile and desktop. Keep up the good work.

    1
  • AjeaS•715
    @AjeaSmithPosted about 5 years ago

    Great job Alex, I admire how organized your codebase is! very easy to understand and read through. Your solution looks great, keep up the good work!

    1